Correct the sflow default sample rate #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- What I did Correct the sflow default sample rate to "ifSpeed / 1e6". - Why I did it According the PR: SONiC#746, the sample rate should be "ifSpeed / 1e6". - How I verified it - Details if related Signed-off-by: Fred Yu fred_yu@edge-core.com
|
@dgsudharsan , @padmanarayana to review |
dgsudharsan
previously approved these changes
Feb 3, 2021
padmanarayana
previously approved these changes
Feb 3, 2021
fredyu190011
dismissed stale reviews from padmanarayana and dgsudharsan
via
99acf5d
dgsudharsan
previously approved these changes
Feb 3, 2021
padmanarayana
previously approved these changes
Feb 3, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@fredyu190011 , can you please do a force-push? |
|
Hi @prsunny , I solve the conflict through merge. Is it okay? |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@fredyu190011 Please address my latest comments. |
fredyu190011
dismissed stale reviews from padmanarayana and dgsudharsan
via
5900bf7
|
Hi @dgsudharsan , I cannot see your latest comment. |
dgsudharsan
approved these changes
Apr 1, 2021
| #define SFLOW_SAMPLE_RATE_VALUE_10G "1000" | ||
| #define SFLOW_SAMPLE_RATE_VALUE_1G "100" | ||
| #define SFLOW_SAMPLE_RATE_VALUE_400G "400000" | ||
| #define SFLOW_SAMPLE_RATE_VALUE_100G "100000" |
There was a problem hiding this comment.
Please add 200G speed sample rate value. It got missed in the merge I assume
| @@ -1,12 +1,12 @@ | |||
| class TestSflow: | |||
| speed_rate_table = { | |||
| "400000": "40000", | |||
| "100000": "10000", | |||
There was a problem hiding this comment.
Can you please add 200G here too?
|
@prsunny Can we merge this? |
|
Please add it for 202012 branch. |
prsunny
approved these changes
Apr 1, 2021
yxieca
pushed a commit
that referenced
this pull request
Apr 8, 2021
According the PR: SONiC#746, the sample rate should be "ifSpeed / 1e6". Signed-off-by: Fred Yu fred_yu@edge-core.com
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
According the PR: SONiC#746, the sample rate should be "ifSpeed / 1e6". Signed-off-by: Fred Yu fred_yu@edge-core.com
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Restored cfggen sort method of json data and used it to sort config db before saving. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Correct the sflow default sample rate to "ifSpeed / 1e6".
Why I did it
According the PR: SONiC#746, the sample rate should be "ifSpeed / 1e6".
How I verified it
Details if related
Signed-off-by: Fred Yu fred_yu@edge-core.com