Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vstest] VS test failure fix after fabric port orch PR merge #1811

Merged
merged 3 commits into from
Dec 7, 2021
Merged

[vstest] VS test failure fix after fabric port orch PR merge #1811

merged 3 commits into from
Dec 7, 2021

Commits on Dec 7, 2021

  1. [vstest] VS test failues fix after fabric port orch PR merge 

    Changes include:

- Set the FABRIC_NUM_PORTS to 16. This is required since addition of
fabric port orch adds 16 fabrics in asic db internally.
- Added back the skipped tests

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
    vedganes committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    e739083 View commit details
    Browse the repository at this point in the history

  2. [vstest] Code review comments fix - 1 

    Changes done to remove comments and LGTM warnings.

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
    vedganes committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    bb42224 View commit details
    Browse the repository at this point in the history

  3. Revert "[VS test] Skip flaky virtual chassis test (sonic-net#2004)" 

    This reverts commit facdef5.

With the changes in platfrom/vs/docker-sonic-vs/start.sh done via
sonic-buildimage PR sonic-net/sonic-buildimage#8008
all tests will pass. No need to skip the tests.

So reverting this commit
    vedganes committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    460244f View commit details
    Browse the repository at this point in the history