Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured #1822

Merged
merged 3 commits into from
Jul 29, 2021

Commits on Jul 15, 2021

  1. Bug fix: Don't create lossless buffer profile for ports without speed…

    … configured
    
    Root cause:
    - In handlePortTableUpdate, refreshPgsFromPort is called if admin status is updated even if the speed is not configured.
      This is reasonable because the port can be configured as headroom override and the profile should be applied in that case.
    - However, the port's state is set to PORT_READY in refreshPgsForPort regardless whether speed is configured, which is not correct.
      This is should be avoided and PORT_READY should be set by caller if necessary
    Fix:
    - Don't set port's state to READY in refreshPgsForPort
    - Explicitly set port's state to READY in handlePortState. This has been done by all other callers.
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    d41ed71 View commit details
    Browse the repository at this point in the history
  2. Check the port's state before calling refreshPgsForPort

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    eb75044 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Configuration menu
    Copy the full SHA
    60a0254 View commit details
    Browse the repository at this point in the history