Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge mac setting and fix for mux statedb time format #1844

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Bridge mac setting and fix for mux statedb time format #1844

merged 1 commit into from
Aug 2, 2021

Conversation

prsunny
Copy link
Collaborator

@prsunny prsunny commented Jul 30, 2021

What I did

  1. Set bridge mac same as Vlan mac
  2. Format state_db entries to have six digit precision for microseconds

Why I did it
Avoid flooding of self destined packets and consistent formating for MUX METRICS

How I verified it

  1. Bridge Mac

Prior to fix:

admin@sonic$ ip link show Vlan1000
53: Vlan1000@Bridge: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9100 qdisc noqueue state UP 
    link/ether **00:aa:bb:cc:dd:ee** brd ff:ff:ff:ff:ff:ff

admin@sonic$ ip link show Bridge
51: Bridge: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9100 qdisc noqueue state UP 
    link/ether **94:8e:d3:04:bf:d8** brd ff:ff:ff:ff:ff:ff

After fix:

admin@sonic$ ip link show Vlan1000
97: Vlan1000@Bridge: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9100 qdisc noqueue state UP 
    link/ether **00:00:11:22:33:44** brd ff:ff:ff:ff:ff:ff

admin@sonic$ ip link show Bridge
93: Bridge: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9100 qdisc noqueue state UP 
    link/ether **00:00:11:22:33:44** brd ff:ff:ff:ff:ff:ff
  1. STATE_DB

Before fix:

admin@sonic$ redis-cli -n 6 hgetall "MUX_METRICS_TABLE|Ethernet4"
5) "orch_switch_active_start"
6) "2021-Jul-29 23:55:24.1364"             <== No fixed format
7) "orch_switch_active_end"
8) "2021-Jul-29 23:55:24.3377"

After fix:

admin@str2-7050cx3-acs-02:~$ redis-cli -n 6 hgetall "MUX_METRICS_TABLE|Ethernet4"
3) "orch_switch_standby_end"
4) "2021-Jul-30 00:03:24.000275"        <== Fixed 6 point formating

Details if related

Created a test-gap to cover Bridge mac flood scenario - sonic-net/sonic-mgmt#3916

@prsunny prsunny merged commit e65aec9 into sonic-net:master Aug 2, 2021
@prsunny prsunny deleted the precision branch August 2, 2021 15:05
@vaibhavhd vaibhavhd mentioned this pull request Aug 2, 2021
Merged
5 tasks
qiluo-msft pushed a commit that referenced this pull request Aug 3, 2021
@prsunny @qiluo-msft
Bridge mac setting, fix statedb time format (#1844)
41dfaad 
*Set bridge mac same as Vlan mac
*Format state_db entries to have six digit precision for microseconds
vaibhavhd added a commit to sonic-net/sonic-buildimage that referenced this pull request Aug 3, 2021
@vaibhavhd
[advance submodule] Update sonic-swss master head to latest (#8313)
4d92f94 
Update sonic-swss submodule head to include below fixes:

Ignore ALREADY_EXIST error in FDB creation (sonic-net/sonic-swss#1815)
Update MACsec SA PN counter to support SAI API 1.8 (sonic-net/sonic-swss#1818)
[swss]: Allow portsyncd to run on system without ports (sonic-net/sonic-swss#1808)
[debugcounterorch] check if counter type is supported before querying… (sonic-net/sonic-swss#1789)
[configure.ac] Add the option of passing libnl path to configure script (sonic-net/sonic-swss#1824)
refactor(fdbsyncd): Convert files with dos2unix (sonic-net/sonic-swss#1828)
[VS] Fix for VS test failures (sonic-net/sonic-swss#1836)
Td2: Reclaim buffer from unused ports (sonic-net/sonic-swss#1830)
[gearbox] Set context for phys based on configs (sonic-net/sonic-swss#1826)
[Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net/sonic-swss#1822)
Bridge mac setting, fix statedb time format (sonic-net/sonic-swss#1844)
[cfgmgr]: Introduce common libs. (sonic-net/sonic-swss#1842)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@vaibhavhd
[advance submodule] Update sonic-swss master head to latest (sonic-ne…
2641388 
…t#8313)

Update sonic-swss submodule head to include below fixes:

Ignore ALREADY_EXIST error in FDB creation (sonic-net/sonic-swss#1815)
Update MACsec SA PN counter to support SAI API 1.8 (sonic-net/sonic-swss#1818)
[swss]: Allow portsyncd to run on system without ports (sonic-net/sonic-swss#1808)
[debugcounterorch] check if counter type is supported before querying… (sonic-net/sonic-swss#1789)
[configure.ac] Add the option of passing libnl path to configure script (sonic-net/sonic-swss#1824)
refactor(fdbsyncd): Convert files with dos2unix (sonic-net/sonic-swss#1828)
[VS] Fix for VS test failures (sonic-net/sonic-swss#1836)
Td2: Reclaim buffer from unused ports (sonic-net/sonic-swss#1830)
[gearbox] Set context for phys based on configs (sonic-net/sonic-swss#1826)
[Dynamic Buffer Calc] Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net/sonic-swss#1822)
Bridge mac setting, fix statedb time format (sonic-net/sonic-swss#1844)
[cfgmgr]: Introduce common libs. (sonic-net/sonic-swss#1842)
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
@prsunny @raphaelt-nvidia
Bridge mac setting, fix statedb time format (sonic-net#1844)
5736c8f 
*Set bridge mac same as Vlan mac
*Format state_db entries to have six digit precision for microseconds
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@yxieca
[show techsupport] fix bash errors in generate_dump script (sonic-net…
280dd29 
…#1844)

What I did
Fix: sonic-net/sonic-buildimage#8850

Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge)

The error_handler is a great idea but the bash script needs to be error free first.

How I did it
Fix bash script errors.

How to verify it
run show techsupport test..

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tahmed-dev tahmed-dev tahmed-dev approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
Included in 202012 Branch Request for 202012 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prsunny @tahmed-dev @qiluo-msft