[nhg]: Add support for weight in nexthop group member. #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In fpmsyncd, parse weight field in nlmsg, set APP_DB if weight is set. 2. In routeorch, collect weight and pass weight attribute to next hop group memeber object. Signed-off-by: Zhenghui Cai <zcai@juniper.net>
|
This pull request introduces 3 alerts when merging 775f2db into 7aca82d - view on LGTM.com new alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can you please give a reference to original PR which was reverted? |
|
Original PR here: #1752 |
prsunny
approved these changes
Aug 11, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* * Add support for weight in nexthop group member. 1. In fpmsyncd, parse weight field in nlmsg, set APP_DB if weight is set. 2. In routeorch, collect weight and pass weight attribute to next hop group memeber object. Signed-off-by: Zhenghui Cai <zcai@juniper.net>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did
Added the PortChannel and PortChannel_Member Modules to the Debug Dump Utility
Added the Corresponding UT's
Note: Portchannel member accepts the keys of PORTCHANNEL_MEMBER table as the Identifier and since the key contains this character ("|"), this should be escaped using single quotes while using the utility i.e.
dump state portchannel_member 'PortChannel001|Ethernet4,PortChannel001|Ethernet8'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
In order to set weight for next hop group members. To support weighted ECMP.
How I verified it
Details if related
This has all the fixes for PR #1752 and added negative testing for checking weight if the database entry is not complete.