Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported #1857

Merged

Commits on Aug 6, 2021

  1. [Bugfix] Don't query SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES i…

    …f it is not supported by a pool
    
    Currently, SAI_BUFFER_POOL_STAT_WATERMARK_BYTES and SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES are queried for buffer pools.
    However, the latter is not supported on all pools and all platforms, which will results in sairedis complaint
    To avoid that, we need to test whether it is supported before putting it to FLEX_COUNTER table
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    8a6fde7 View commit details
    Browse the repository at this point in the history
  2. Fix comments

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    d58455b View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Use get_buffer_pool_stats instead of get_buffer_pool_stats_ext

    The latter is not supported by all vendors
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    87cf819 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Change the counter IDs being tested before enable buffer pool waterma…

    …rk polling
    
    - If shared headroom pool watermark is not supported,
      only buffer pool watermark will be tested
    - Otherwise, both buffer pool watermark and shared headroom pool watermark will be checked
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    fca084b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Update bufferorch.cpp

    Fix review comments.
    stephenxs authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    628949e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Replace all "Shp" to "SharedHeadroomPool" for better understanding

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    c7835cc View commit details
    Browse the repository at this point in the history