[portsorch] Add an extra check before setting oper speed to APPL_DB #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Sep 3, 2021
orchagent/portsorch.cpp
Outdated
| @@ -5252,8 +5252,22 @@ void PortsOrch::doTask(NotificationConsumer &consumer) | |||
| sai_uint32_t speed; | |||
| if (getPortOperSpeed(port, speed)) | |||
| { | |||
| SWSS_LOG_NOTICE("%s oper speed is %d", port.m_alias.c_str(), speed); | |||
| updateDbPortOperSpeed(port, speed); | |||
| if (speed != 0) | |||
There was a problem hiding this comment.
Should we just return false from getPortOperSpeed if speed is 0. Just a thought?
prsunny
approved these changes
Sep 7, 2021
5 tasks
|
Hi @judyjoseph, could you please help cherry-pick to 202016. |
judyjoseph
pushed a commit
that referenced
this pull request
Sep 14, 2021
…1885) * [portsorch] Add an extra check before setting oper speed to APPL_DB
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…onic-net#1885) * [portsorch] Add an extra check before setting oper speed to APPL_DB
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
… checkpoint, list-checkpoints} (sonic-net#1885) #### What I did Adding more logging to other CLI commands `config replace`, `config rollback`, `config checkpoint`, `config list-checkpoints` and `config delete-checkpoint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
If port operational status is up and port operational speed is 0, don't save it to APPL_DB
Why I did it
Avoid put speed 0 to APPL_DB.
Port operational status is up, but operational speed is 0. It could be a valid case because
port UP event is an aync event, the valid flow could be:
And it could also be a bug. So, we log a warning here.
How I verified it
Run sonic-mgmt regression test cases
Details if related