[cfgmgr] Fix for STATE_DB Port check logic in cfgmgr daemons #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change lgtm, but this would be a working function broken. Do you know which PR introduced the change? |
|
@Junchao-Mellanox , could you please take a look at this? In #1714, it is not mentioned in description about any STATE_DB update and looks like there are impact on cfgmgrs. |
prsunny
approved these changes
Oct 2, 2021
|
@prsunny I see this PR is approved by you... Are you waiting for feedback from @Junchao-Mellanox before merging? |
Yes |
Junchao-Mellanox
approved these changes
Oct 11, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 14, 2021
*Updated checks for PORT entry in STATE_DB in portmgrd, teammgrd, and intfmgrd to additionally check for presence of "state" attribute.
|
@qbdwlr , @Junchao-Mellanox , isn't this applicable here as well |
This was referenced Oct 25, 2021
prsunny
pushed a commit
that referenced
this pull request
Oct 28, 2021
* Updated checks for PORT entry in STATE_DB in vlanmgrd additionally check for presence of "state" attribute. This is to add Vlanmgrd check similar to #1936 Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
judyjoseph
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Updated checks for PORT entry in STATE_DB in vlanmgrd additionally check for presence of "state" attribute. This is to add Vlanmgrd check similar to #1936 Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Updated checks for PORT entry in STATE_DB in portmgrd, teammgrd, and intfmgrd to additionally check for presence of "state" attribute.
Why I did it
Prior to recent commits for PORT auto-negotiation, 3 daemons in cfgmgr (portmgrd, teammgrd, and intfmgrd) would not allow configuration to proceed for a specific PORT until portsyncd detected the presence of the kernel device (EthernetN) associated with the PORT and created the associated entry for the PORT in the STATE_DB with attribute "state" and value "ok".
With recent commits for PORT auto-negotiation, this logic is now broken due to creation of PORT entry in the STATE_DB by PortsOrch with only "supported_speed" attribute.
The logic in the 3 cfgmgr daemons has been updated to additionally check for the "state" attribute when they detect the presence of the PORT entry in STATE_DB.
How I verified it
SONiC unit-tests and platform tests.
Details if related
N/A