[aclorch] add generic AclOrch::updateAclRule() method

[stepanblyschak]

What I did

I added generic AclOrch::updateAclRule() implementation. This implementation takes a newly constructed shared_ptr<AclRule> provided by the user, calculates a difference between priority, matches and actions and calls sai_acl_api->set_acl_entry_attribute() for those attributes that were changed. The derivatives of AclRule can customize the behaviour of AclRule::update(const AclRule& updatedRule) by polymorphic override, although in that case the derivative needs dynamic_cast the updatedRule to a concrete derivative type.
Added unit test to cover update scenario. Currently this new API is not used by any clients nor handling ACL_RULE table updates. This API will be used by PBH ACL rule update flow.

Why I did it

To support the scenario for updating PBH ACL rule in the future.

How I verified it

Temporary changed the ACL_RULE table update to leverage this new API and tested updates through CONFIG_DB and unit test coverage.

Details if related

[prsunny]

@stepanblyschak, the changes looks to be significant. Is there any document covering this new change? Request @bingwang-ms and @anish-n to sign-off

[stepanblyschak]

@prsunny This is briefly covered https://github.com/azure/SONiC/blob/master/doc/acl/ACL-Table-Type-HLD.md#acl-rule-update

[bingwang-ms]

Reviewing

[stepanblyschak]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[bingwang-ms]

Please ping me when the PR is ready for review. Thanks

[stepanblyschak]

@bingwang-ms This PR is ready.

[bingwang-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stepanblyschak]

There is some issue with LGTM:

[2021-11-18 13:03:05] [build-stdout] g++ -DHAVE_CONFIG_H -I. -I.. -I .. -g -DNDEBUG  -ansi -fPIC -std=c++11 -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Winvalid-pch -Wlong-long -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wno-write-strings -Wno-missing-format-attribute -Wno-long-long  -I/usr/include/libnl3  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/opt/src/sonic-swss-common=. -fstack-protector-strong -Wformat -Werror=format-security -c -o tests-saiaclschema_ut.o `test -f 'saiaclschema_ut.cpp' || echo './'`saiaclschema_ut.cpp
[2021-11-18 13:03:05] [build-stderr] saiaclschema_ut.cpp:1:10: fatal error: gmock/gmock.h: No such file or directory
[2021-11-18 13:03:05] [build-stderr]     1 | #include <gmock/gmock.h>
[2021-11-18 13:03:05] [build-stderr]       |          ^~~~~~~~~~~~~~~
[2021-11-18 13:03:05] [build-stderr] compilation terminated.

[stepanblyschak]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stepanblyschak]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stepanblyschak]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).