[orchagent] Flush pipeline every 1 second, not only when select will timeout #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i actually don't like much this solution, so if you have any other one in mind, let me know |
shi-su
approved these changes
Nov 4, 2021
|
@prsunny hey, are you OK to merge this despite of failing tests ? each time is different set |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
#### What I did
Show the default enum for the option `--format`
#### How I did it
Added `show_default=True`
#### How to verify it
Checkout output below
#### Previous command output (if the output of a command-line utility has changed)
```bash
admin@vlab-01:~$ sudo config apply-patch -h
Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH
Apply given patch of updates to Config. A patch is a JsonPatch which
follows rfc6902. This command can be used do partial updates to the config
with minimum disruption to running processes. It allows addition as well
as deletion of configs. The patch file represents a diff of ConfigDb(ABNF)
format or SonicYang format.
<patch-file-path>: Path to the patch file on the file-system.
Options:
-f, --format [CONFIGDB|SONICYANG]
format of config of the patch is either
ConfigDb(ABNF) or SonicYang
-d, --dry-run test out the command without affecting
config state
-v, --verbose print additional details of what the
operation is doing
-h, -?, --help Show this message and exit.
admin@vlab-01:~$
```
#### New command output (if the output of a command-line utility has changed)
```sh
admin@vlab-01:~$ sudo config apply-patch -h
Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH
Apply given patch of updates to Config. A patch is a JsonPatch which
follows rfc6902. This command can be used do partial updates to the config
with minimum disruption to running processes. It allows addition as well
as deletion of configs. The patch file represents a diff of ConfigDb(ABNF)
format or SonicYang format.
<patch-file-path>: Path to the patch file on the file-system.
Options:
-f, --format [CONFIGDB|SONICYANG]
format of config of the patch is either
ConfigDb(ABNF) or SonicYang [default:
CONFIGDB]
-d, --dry-run test out the command without affecting
config state
-v, --verbose print additional details of what the
operation is doing
-h, -?, --help Show this message and exit.
admin@vlab-01:~$
```
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 14, 2022
…timeout (#2003) * Added flush for async communication pipeline, every 1 second, not only if select will timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added flush for async communication pipeline, every 1 second, not only if select will timeout.
Why I did it
pfcwdorch has a executor timeout which triggers select every second, and somehow from some time select never timeouts (its timeout is also 1 second) and every time is returning valid object, not causing async pipeline to flush, which causes for some operations to wait for next synchronous operation to be processed.
How I verified it
Tested thanks to @shi-su
Details if related