Fix next hop compilation #2025
Merged
Fix next hop compilation #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
why is lgtm failing? @kperumalbfn , please review |
|
LGTM fails because it tries to compile the previous commit for comparison |
prsunny
approved these changes
Nov 12, 2021
|
@TACappleman Not sure why it is failing after merge. |
kperumalbfn
approved these changes
Nov 12, 2021
|
@kperumalbfn the previous commit (which merged around the same time) referenced one of the functions you'd added a variable to. There was no merge conflict between them, but the combo then couldn't compile |
Thanks @TACappleman |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed compilation of SWSS following last 2 commits
Why I did it
Last 2 commits don't compile together due to change in nexthop(group)key definitions
How I verified it
Compiled with this fix
Details if related