Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try get port operational speed from STATE DB #2119

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Jan 24, 2022

HLD change: sonic-net/SONiC#932

What I did

  1. Put port operational speed to STATE DB
  2. Remove previous workaround [orchagent] Put port configuration to APPL_DB according to autoneg mode #1769

Why I did it

For issue sonic-net/sonic-buildimage#9595

How I verified it

Manual test

Details if related

portsyncd/portsyncd.cpp Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
orchagent/portsorch.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @prgeor to approve/merge

@prsunny prsunny dismissed their stale review February 25, 2022 21:37

Changes lgtm

@liat-grozovik liat-grozovik changed the title Try get port operatinal speed from STATE DB Try get port operational speed from STATE DB Feb 28, 2022
@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@prgeor
Copy link
Contributor

prgeor commented Mar 1, 2022

@Junchao-Mellanox can you check the LGTM failure

}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tab space?

@prsunny
Copy link
Collaborator

prsunny commented Mar 1, 2022

@Junchao-Mellanox can you check the LGTM failure

@prgeor , this is a known issue

@prsunny prsunny merged commit 0a99f54 into sonic-net:master Mar 1, 2022
@Junchao-Mellanox Junchao-Mellanox deleted the optimize-port-auto-neg branch March 2, 2022 06:45
judyjoseph pushed a commit that referenced this pull request Mar 7, 2022
* Put port operational speed to STATE DB
* Remove previous workaround [orchagent] Put port configuration to APPL_DB according to autoneg mode #1769
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
* Put port operational speed to STATE DB
* Remove previous workaround [orchagent] Put port configuration to APPL_DB according to autoneg mode sonic-net#1769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants