Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[neighsyncd] Enabling ipv4 link local entries for non-dualtor #2427

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

Ndancejic
Copy link
Contributor

Allow ipv4 link local entries to be programmed to the hardware unless on
a dual-tor setup.

fixing sonic-net/sonic-buildimage#11830

Signed-off-by: Nikola Dancejic ndancejic@microsoft.com

Allow ipv4 link local entries to be programmed to the hardware unless on
a dual-tor setup.

fixing sonic-net/sonic-buildimage#11830

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
@@ -431,12 +431,12 @@ def test_Ipv4LinkLocalNeighbor(self, dvs, testlog):
# check application database
tbl = swsscommon.Table(self.pdb, "NEIGH_TABLE:Ethernet8")
intf_entries = tbl.getKeys()
assert len(intf_entries) == 0
assert len(intf_entries) == 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to cover dualtor case?

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request fixes 1 alert when merging d91e336 into 4aaeec9 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 25, 2022

This pull request fixes 1 alert when merging 424aa4a into 4aaeec9 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@prsunny
Copy link
Collaborator

prsunny commented Aug 30, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit 8cc0a45 into sonic-net:master Aug 30, 2022
yxieca pushed a commit that referenced this pull request Sep 1, 2022
* [neighsyncd] Enabling ipv4 link local entries for non-dualtor
Allow ipv4 link local entries to be programmed to the hardware unless on
a dual-tor setup.
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Sep 1, 2022
Update sonic-swss submodule pointer to include the following:
* [BFD]Clean up state_db BFD entries on swss restart ([sonic-net#2434](sonic-net/sonic-swss#2434))
* Fix the Fec Mode Setting of gbsyncd ([sonic-net#2430](sonic-net/sonic-swss#2430))
* [neighsyncd] Enabling ipv4 link local entries for non-dualtor ([sonic-net#2427](sonic-net/sonic-swss#2427))
* tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408))
* PFCWD recovery changes using DLR_INIT ([sonic-net#2316](sonic-net/sonic-swss#2316))
* Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194))

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants