[DPU] Simplify SWSS initialization to meet DPU requirements. #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
prsunny
reviewed
Sep 16, 2022
orchagent/orchdaemon.cpp
Outdated
| vector<string> p4rt_tables = {APP_P4RT_TABLE_NAME}; | ||
| gP4Orch = new P4Orch(m_applDb, p4rt_tables, vrf_orch, gCoppOrch); | ||
| m_orchList.push_back(gP4Orch); | ||
| if (gMySwitchType != "dpu") |
There was a problem hiding this comment.
Is this applicable? This should not be impacting even if initialized, correct?
There was a problem hiding this comment.
After reworking of P4Orch this is not needed anymore.
portsyncd/linksync.cpp
Outdated
| /* In DPU SONiC this step is not needed as netdevs in Kernel are created in the early stage of the syncd service start, | ||
| * when driver is loading. And exist while the driver is not unloaded. | ||
| */ | ||
| if (g_switchType != "dpu") |
There was a problem hiding this comment.
Can we just add the check and return if dpu. If other platform require this in future, lets address it accordingly.
|
@prsunny I resolved all the comments. Can you please take a look? |
prsunny
approved these changes
Sep 19, 2022
prsunny
pushed a commit
that referenced
this pull request
Oct 11, 2022
* [DPU] Simplify SWSS initialization to meet DPU requirements. Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
Pterosaur
pushed a commit
to Pterosaur/sonic-swss
that referenced
this pull request
Nov 5, 2022
…et#2440) * [DPU] Simplify SWSS initialization to meet DPU requirements. Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
oleksandrivantsiv
added a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Dec 21, 2022
…et#2440) * [DPU] Simplify SWSS initialization to meet DPU requirements. Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 21, 2023
…et#2440) * [DPU] Simplify SWSS initialization to meet DPU requirements. Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 25, 2023
…et#2440) * [DPU] Simplify SWSS initialization to meet DPU requirements. Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 27, 2023
sonic-net#2440) * [DPU] Simplify SWSS initialization to meet DPU requirements. Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksandr Ivantsiv oivantsiv@nvidia.com
What I did
DPU supports features subset from Switch SONiC. To allow SWSS to run on DPU the initialization flow was simplified. During the start of the SWSS applications unsupported attributes are not configured. The list of SAI attributes supported by DPU is documented in DASH HLD.
Why I did it
To allow the SWSS application to run on DPU.
How I verified it
Run SWSS on DPU platform. Verify that unsupported attributes are not called.
Run SONiC as VS set as switch type DPU
Details if related