Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][asan] add DVS tests run with ASAN #2441

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

Yakiv-Huryk
Copy link
Contributor

This adds 3 new stages:

  • BuildAsan: same as 'Build' but with ENABLE_ASAN=y
  • BuildDockerAsan: same as 'BuildDocker' but uses asan-enabled swss and
    adds swss-dbg package. It also uses asan-enabled docker-sonic-vs from
    the sonic-buildimage ci.
  • TestAsan: same as 'Test' but uses asan-enabled docker and publishes
    the asan reports if any. It also shows a warning if asan report dir is not empty
    (which means that there is some memory usage issue in swss)

What I did
Added new CI stages to run the DVS tests with ASAN and check the ASAN reports.

Why I did it
To utilize ASAN for catching memory usage issues on PR.

How I verified it
Run the CI on my fork.

Details if related

This adds 3 new stages:

* BuildAsan: same as 'Build' but with ENABLE_ASAN=y
* BuildDockerAsan: same as 'BuildDocker' but uses asan-enabled swss and
adds swss-dbg package. It also uses asan-enabled docker-sonic-vs from
the sonic-buildimage ci.
* TestAsan: same as 'Test' but uses asan-enabled docker and publishes
the asan reports if any. It also shows a warning if asan report dir is not empty
(which means that there is some memory usage issue in swss)

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
@liat-grozovik
Copy link
Collaborator

@xumia could you please help to review?

@liat-grozovik
Copy link
Collaborator

@prsunny , @xumia could you please help to review

@xumia
Copy link
Collaborator

xumia commented Sep 20, 2022

/azp run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -49,6 +49,19 @@ stages:
archive_pytests: true
archive_gcov: true

- stage: BuildAsan

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the BuildAsan stage have dependency on Build stage, if not, you can add the dependsOn:[] to skip it, it will run in parallel with Build stage.

- stage: BuildAsan
  dependsOn: []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks. I've updated the PR.

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants