orchagent: DASH changes #2459
Merged
orchagent: DASH changes #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhataravind
force-pushed
the
dash
branch
from
5bb999c to
f438a10
Compare
prsunny
requested review from
Pterosaur,
theasianpianist and
oleksandrivantsiv
Pterosaur
reviewed
Sep 25, 2022
marian-pritsak
requested changes
Sep 27, 2022
|
Do we intend to set admin state of ENI? |
Pterosaur
reviewed
Sep 28, 2022
Merged
prabhataravind
requested review from
Pterosaur
and removed request for
theasianpianist,
prsunny and
oleksandrivantsiv
|
Yes, I have fixed this. |
prsunny
requested changes
Oct 18, 2022
| void doTaskRoutingTypeTable(Consumer &consumer); | ||
| bool addApplianceEntry(const std::string& appliance_id, const ApplianceEntry &entry); | ||
| bool removeApplianceEntry(const std::string& appliance_id); | ||
| bool addRoutingTypeEntry(const std::string& routing_type, const RoutingTypeEntry &entry); |
There was a problem hiding this comment.
RoutingTypeEntry is expected to be a list
There was a problem hiding this comment.
Will fix this in a subsequent commit along with handling list of actions for DASH_ROUTING_TYPE_TABLE
oleksandrivantsiv
suggested changes
Oct 18, 2022
theasianpianist
approved these changes
Oct 25, 2022
* Introduce DASH specific orchs - DashOrch, DashVnetOrch and DashRouteOrch * Introduce changes to handle various DASH table schemas and operations * Changes in bulker to introduce new constructors for DASH-related Entity/Object bulkers * Changes to support new DASH tables and orchs in orchdaemon * Changes to support new DASH APIs in saihelper * Makefile changes to support compilation * References: https://github.com/Azure/DASH/blob/main/documentation/general/design/dash-sonic-hld.md * Verifications done: Manual testing with configurations referenced in the HLD above. * Issues: Intermittent failures with bulk operations on DASH_VNET_MAPPING_TABLE, dependency related failures when deleting DASH_VNET objects when there are objects with references to these objects that are yet to be deleted. Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
* Address review comments * Gracefully handle certain error conditions during bulk set/del operations Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
* Avoid "using" directives for namespaces in dash headers
* Make equality checks for dash objects more robust
* Clear pa_validation_object_statuses as well in VnetMapBulkContext clear()
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
* Move ENI and QOS to DashOrch
* Make ENI table handling simpler
* Fix generation of hash seed for DASH entries
* Avoid setting of explicit default values for QOS attributes
* Changing log levels as appropriate to avoid incessant logging
* Miscellaneous cosmetic code cleanups
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
* Address handling of IPv6 keys for DASH_ROUTING_TABLE, DASH_ROUTING_RULE_TABLE and DASH_VNET_MAPPING_TABLE Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
prabhataravind
requested review from
prsunny and
oleksandrivantsiv
and removed request for
Pterosaur and
prsunny
prsunny
approved these changes
Nov 4, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Dec 21, 2022
* orchagent: DASH changes * Introduce DASH specific orchs - DashOrch, DashVnetOrch and DashRouteOrch * Introduce changes to handle various DASH table schemas and operations * Changes in bulker to introduce new constructors for DASH-related Entity/Object bulkers * Changes to support new DASH tables and orchs in orchdaemon * Changes to support new DASH APIs in saihelper * Makefile changes to support compilation * References: https://github.com/Azure/DASH/blob/main/documentation/general/dash-sonic-hld.md * Verifications done: Manual testing with configurations referenced in the HLD above as well as automated vstests Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 21, 2023
* orchagent: DASH changes * Introduce DASH specific orchs - DashOrch, DashVnetOrch and DashRouteOrch * Introduce changes to handle various DASH table schemas and operations * Changes in bulker to introduce new constructors for DASH-related Entity/Object bulkers * Changes to support new DASH tables and orchs in orchdaemon * Changes to support new DASH APIs in saihelper * Makefile changes to support compilation * References: https://github.com/Azure/DASH/blob/main/documentation/general/dash-sonic-hld.md * Verifications done: Manual testing with configurations referenced in the HLD above as well as automated vstests Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 25, 2023
* orchagent: DASH changes * Introduce DASH specific orchs - DashOrch, DashVnetOrch and DashRouteOrch * Introduce changes to handle various DASH table schemas and operations * Changes in bulker to introduce new constructors for DASH-related Entity/Object bulkers * Changes to support new DASH tables and orchs in orchdaemon * Changes to support new DASH APIs in saihelper * Makefile changes to support compilation * References: https://github.com/Azure/DASH/blob/main/documentation/general/dash-sonic-hld.md * Verifications done: Manual testing with configurations referenced in the HLD above as well as automated vstests Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 27, 2023
* orchagent: DASH changes * Introduce DASH specific orchs - DashOrch, DashVnetOrch and DashRouteOrch * Introduce changes to handle various DASH table schemas and operations * Changes in bulker to introduce new constructors for DASH-related Entity/Object bulkers * Changes to support new DASH tables and orchs in orchdaemon * Changes to support new DASH APIs in saihelper * Makefile changes to support compilation * References: https://github.com/Azure/DASH/blob/main/documentation/general/dash-sonic-hld.md * Verifications done: Manual testing with configurations referenced in the HLD above as well as automated vstests Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce DASH specific orchs - DashOrch, DashVnetOrch and DashRouteOrch
Introduce changes to handle various DASH table schemas and operations
Changes in bulker to introduce new constructors for DASH-related Entity/Object bulkers
Changes to support new DASH tables and orchs in orchdaemon
Changes to support new DASH APIs in saihelper
Makefile changes to support compilation
References: https://github.com/Azure/DASH/blob/main/documentation/general/design/dash-sonic-hld.md
Verifications done: Manual testing with configurations referenced in the HLD above.
Issues: Intermittent failures with bulk operations on DASH_VNET_MAPPING_TABLE, dependency related failures when deleting DASH_VNET and DASH_ENI objects when there are objects with references to these objects that are yet to be deleted.
Signed-off-by: Prabhat Aravind paravind@microsoft.com
What I did
Why I did it
How I verified it
Details if related