[vstest] Only collect stdout of orchagent_restart_check in vstest #2578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is to fix the flaky test cases in vstest.
We frequently saw test failures in PR testing like below
The output is produced by gcov. However, it's collected into the output of
orchagent_restart_check
and leads to test failure because the output is not as expected.This PR fixes the issue by adding an argument
include_stderr
toruncmd
. Wheninclude_stderr
is set toFalse
, only stdout is collected.Why I did it
This PR is to fix the flaky test cases in vstest.
How I verified it
Verified by running vstest locally.
Details if related