[202012][muxorch] handling multiple mux nexthops for route #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I did: added logic to handle when a route points to a nexthop group with mux neighbors. In this case, only one active neighbor, or the tunnel nexthop will be programmed to the ASIC. Why I did it: having a route with multiple mux neighbors caused a data loop which lead to packet loss when different neighbors were in different states. How I did it: added logic to update routes when a route is changed, a mux neighbor is changed, or there is a mux state change. HLD: sonic-net/SONiC#1256 Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Ndancejic
force-pushed
the
multi-nexthop-202012
branch
from
5507962
to
dd3105c
Compare
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Ndancejic
force-pushed
the
multi-nexthop-202012
branch
from
dd3105c
to
fc97dec
Compare
prsunny
approved these changes
Mar 28, 2023
|
@prsunny - could you please merge this to 202205? |
its already cherry-picked as part of master PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did: added logic to handle when a route points to a nexthop group with mux neighbors. In this case, only one active neighbor, or the tunnel nexthop will be programmed to the ASIC.
Why I did it: having a route with multiple mux neighbors caused a data loop which lead to packet loss when different neighbors were in different states.
How I did it: added logic to update routes when a route is changed, a mux neighbor is changed, or there is a mux state change.
HLD: sonic-net/SONiC#1256
cherry-pick of #2656