Fix orchagent missing request when logrotate happens. #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prsunny can you take a look at this? A very small bug fix. |
theasianpianist
approved these changes
Mar 27, 2023
|
@theasianpianist , can you check if it needs to be backported? |
prsunny
added a commit
to prsunny/sonic-swss
that referenced
this pull request
Mar 29, 2023
theasianpianist
pushed a commit
that referenced
this pull request
Mar 30, 2023
- Cherry picking #2712 - The sairedis logrotate has been moved into the daemon main select loop. After it finishes, it should not continue, because that will drop the event that has been selected.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
May 4, 2023
* Fix orchagent missing request when logrotate happens. (#2712)
StormLiangMS
pushed a commit
that referenced
this pull request
May 25, 2023
* Fix orchagent missing request when logrotate happens. (#2712)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix orchagent request missing when logrotate happens.
Why I did it
The sairedis logrotate has been moved into the daemon main select loop. After it finishes, it should not continue, because that will drop the event that has been selected.
How I verified it
Details if related