Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202211][EVPN]Fixing race condition when EVPN NVO add arrives late #2757

Merged
merged 1 commit into from
May 4, 2023
Merged

[202211][EVPN]Fixing race condition when EVPN NVO add arrives late #2757

merged 1 commit into from
May 4, 2023

Conversation

dgsudharsan
Copy link
Collaborator

Manual cherry-pick of #2756

What I did
Sometime during config reload, EVPN NVO table arrives later than remote VNI table entries. In such scenarios, remote vni entries are ignored and this leads to traffic loss. Added fix to retry instead of ignoring.

2023-04-30.14:23:40.528130|VXLAN_TUNNEL_MAP_TABLE:vtep1:map_98_Vlan98|SET|vlan:Vlan98|vni:98
2023-04-30.14:23:40.559594|VXLAN_TUNNEL_MAP_TABLE:vtep1:map_99_Vlan99|SET|vlan:Vlan99|vni:99
2023-04-30.14:23:40.572133|VXLAN_REMOTE_VNI_TABLE:Vlan98:1.1.1.1|SET|vni:98
2023-04-30.14:23:40.572180|VXLAN_REMOTE_VNI_TABLE:Vlan98:1.1.1.2|SET|vni:98
2023-04-30.14:23:40.575208|VXLAN_FDB_TABLE:Vlan98:04:3f:72:f7:2d:52|SET|remote_vtep:1.1.1.2|type:dynamic|vni:98
2023-04-30.14:23:40.575240|VXLAN_FDB_TABLE:Vlan98:0c:42:a1:6d:5b:94|SET|remote_vtep:1.1.1.1|type:dynamic|vni:98
2023-04-30.14:23:40.575249|VXLAN_FDB_TABLE:Vlan98:1c:34:da:2c:be:00|SET|remote_vtep:1.1.1.1|type:dynamic|vni:98
2023-04-30.14:23:40.575257|VXLAN_FDB_TABLE:Vlan98:1c:34:da:2c:ca:00|SET|remote_vtep:1.1.1.2|type:dynamic|vni:98
2023-04-30.14:23:40.589995|VXLAN_EVPN_NVO_TABLE:nvo1|SET|source_vtep:vtep1

Why I did it
To fix race condition as stated in the description

How I verified it
Added UT to verify.

Details if related

@dgsudharsan dgsudharsan requested a review from prsunny as a code owner May 3, 2023 18:33
@prsunny prsunny merged commit a484ab8 into sonic-net:202211 May 4, 2023
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request May 4, 2023
@dgsudharsan
[202211][submodule] Update sonic-swss submodule
76cf40c 
Update sonic-swss submodule pointer to include the following:
* a484ab8 [EVPN]Fixing race condition when EVPN NVO add comes late ([sonic-net#2757](sonic-net/sonic-swss#2757))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
@dgsudharsan dgsudharsan mentioned this pull request May 4, 2023
Closed
10 tasks
keboliu added a commit to keboliu/sonic-swss that referenced this pull request May 10, 2023
@keboliu
Revert "[EVPN]Fixing race condition when EVPN NVO add comes late (son…
4e8bb83 
…ic-net#2757)"

This reverts commit a484ab8.
dgsudharsan added a commit to dgsudharsan/sonic-swss that referenced this pull request May 10, 2023
@dgsudharsan
Revert "[EVPN]Fixing race condition when EVPN NVO add comes late (son…
64ba4de 
…ic-net#2757)"

This reverts commit a484ab8.
@dgsudharsan dgsudharsan mentioned this pull request May 10, 2023
Merged
prsunny pushed a commit that referenced this pull request May 10, 2023
@dgsudharsan
Revert "[EVPN]Fixing race condition when EVPN NVO add comes late (#2757…
0c7ed8d 
…)" (#2772)

This reverts commit a484ab8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgsudharsan @prsunny