[swss] add static anycast gateway support #3167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yanjun deng <yadeng@cisco.com>
Signed-off-by: yanjun deng <yadeng@cisco.com>
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Pull request contains merge conflicts. |
prvattem
reviewed
Sep 9, 2024
| @@ -0,0 +1,232 @@ | |||
| extern "C" | |||
There was a problem hiding this comment.
Please add some description about the purpose of fake_routeorch.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
VladimirKuk
reviewed
Feb 13, 2025
| MacAddress sag_mac; | ||
| try | ||
| { | ||
| sag_mac = MacAddress(sag_mac_str); |
There was a problem hiding this comment.
Shouldn't be tested for unicast value only ?
There was a problem hiding this comment.
Yes, we should validate the mac in CLI input.
There was a problem hiding this comment.
What will happen if the configuration received from CONFIG_DB without CLI ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Resync the original SAG support to latest master branch:
#1974
Some improvements based on the original PR:
Why I did it
How I verified it
Details if related