[orchagent] fix "parsePortConfig: Unknown field(mode)" #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failures appear unrelated to this PR |
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing. Warnings harm debugging and can cause wasted cycles when debugging real issues. Signed-off-by: Brad House (@bradh352)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny ping |
prsunny
approved these changes
Dec 17, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny please merge |
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 24, 2024
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 24, 2024
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 2, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 13, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 13, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 15, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 16, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 16, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 17, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 18, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Jan 27, 2025
When using "mode" as defined in https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface: ``` WARNING swss#orchagent: :- parsePortConfig: Unknown field(mode): skipping ... ``` It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When using "mode" as defined in
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-port.yang this warning is emitted for each interface:
It appears this field is not needed in orchagent at all, so we need to at least recognize it as valid then skip processing.
Why I did it
Warnings harm debugging and can cause wasted cycles when debugging real issues.
How I verified it
built via my private fork https://github.com/bradh352/sonic-buildimage and installed on physical switches
Details if related
Signed-off-by: Brad House (@bradh352)