[vlanmgrd]: Do not bring up VLAN members by default #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VLAN members' admin status and MTU are controlled by portmdrd. vlanmgrd shall not bring up and set MTU automatically by default. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
|
@jipanyang please check |
jipanyang
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
This the behavior was inherited from the days of Linux network interface file config control. I guess we don't need it any more.
The legacy configuration might miss the explicit vlan member port admin and mtu setting, that should be taken care of by operator though.
|
yes, the pull request sonic-net/sonic-buildimage#2209 ensures that all VLAN members will have admin status set as up by default |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VLAN members' admin status and MTU are controlled by portmdrd.
vlanmgrd shall not bring up and set MTU automatically by default.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com