Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mclag]:add mclagsyncd #811

Merged
merged 14 commits into from
Mar 22, 2020
Merged

[mclag]:add mclagsyncd #811

merged 14 commits into from
Mar 22, 2020

Conversation

shine4chen
Copy link
Contributor

What I did
add mclagsyncd

Why I did it
accomplish it according to MCLAG HLD document

How I verified it
test it on nephos lab

Details if related
Please refer #sonic-net/SONiC#325

shine4chen and others added 2 commits February 13, 2019 17:59
@shine4chen
Merge pull request #1 from Azure/master
9326978 
pull from origin
add mclag support(sonic-net#2514)
b90dcfb 
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
@shine4chen shine4chen changed the title add mclagsyncd for mclag feature [mclag]:add mclagsyncd Mar 11, 2019
shine.chen added 2 commits March 18, 2019 19:58
Fix show acl table can't display mclag acl rules
636fafc 
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
refine mclagsyncd code
4e372ca 
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
change APP_ACL_TABLE_NAME to APP_ACL_TABLE_TABLE_NAME
1d67eea 
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
@lguohan lguohan requested a review from rlhui August 1, 2019 17:56
gitsabari
gitsabari reviewed Aug 3, 2019
View reviewed changes
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
gitsabari
gitsabari reviewed Aug 16, 2019
View reviewed changes
mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
stcheng
stcheng suggested changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments

mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
optimize acl rule operation
d1873fd 
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
@shine4chen shine4chen mentioned this pull request Aug 30, 2019
Merged
lisahnguyen
lisahnguyen previously approved these changes Sep 18, 2019
View reviewed changes
Copy link

@lisahnguyen lisahnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my review comment.

gitsabari
gitsabari previously approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@gitsabari gitsabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of review comments

refine function name using camelcased
cae6a7b 
Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

retest this please.

refine readData function per selectable base-class change
1ae525a 
Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

retest this please

@lguohan
Copy link
Contributor

lguohan commented Nov 12, 2019

I saw binary in the pr. please remove the binary.

remove binary file
1110f12 
Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

@lguohan Thanks, done

set traffic isolation using ACL_TABLE_MCLAG
ea0b696 
Signed-off-by: shine.chen <shine.chen@mediatek.com>
rlhui
rlhui previously approved these changes Nov 22, 2019
View reviewed changes
@shine4chen
Copy link
Contributor Author

retest this please

stcheng
stcheng previously approved these changes Nov 26, 2019
View reviewed changes
@shine4chen
Copy link
Contributor Author

retest this please

1 similar comment
@shine4chen
Copy link
Contributor Author

retest this please

resolve conflict
b44975f 
Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

@stcheng @rlhui @gitsabari @lisahnguyen I resolved some conflict and system automatically dismiss your approve. Would you please help to review and approve it again ?

@shine4chen shine4chen requested a review from rlhui February 4, 2020 09:17
@shine4chen shine4chen requested review from rlhui and removed request for rlhui February 12, 2020 03:21
@rlhui rlhui merged commit 0de72da into sonic-net:master Mar 22, 2020
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@antony-rheneus
[sonic_installer] Enable ARM64 arch (sonic-net#811)
9a94955 
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@kcudnik
[sairedis] Add sai_dbg_generate_dump api to redis interface (sonic-ne…
00d883c 
…t#811)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjundong jianjundong jianjundong left review comments

@rlhui rlhui rlhui approved these changes

@lisahnguyen lisahnguyen lisahnguyen approved these changes

@gitsabari gitsabari gitsabari approved these changes

@stcheng stcheng stcheng left review comments

Assignees

@rlhui rlhui

Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shine4chen @lguohan @stcheng @gitsabari @lisahnguyen @jianjundong @rlhui