-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VLAN] Add pytest cases to validate different use-case of tagging_mode. #860
Merged
lguohan
merged 7 commits into
sonic-net:master
from
linemma:add_pytest_cases_tagging_mode
Aug 2, 2019
Merged
[VLAN] Add pytest cases to validate different use-case of tagging_mode. #860
lguohan
merged 7 commits into
sonic-net:master
from
linemma:add_pytest_cases_tagging_mode
Aug 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emma Lin <emma_lin@edge-core.com>
linemma
force-pushed
the
add_pytest_cases_tagging_mode
branch
from
May 13, 2019 07:48
598f878
to
05e1e99
Compare
lguohan
approved these changes
May 20, 2019
@linemma , can you resolve conflict? |
@lguohan, done. Please review the modification, thanks. |
retest this please |
can you resolve the conflict? |
@lguohan, resolved, please review. Thanks. |
can you do a rebase so that I can see the exact your changes? |
Sorry, I don't understand. Could you tell me what should I do? |
lguohan
approved these changes
Aug 2, 2019
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add pytest cases to validate different use-case of tagging_mode.
Why I did it
How I verified it
Test cases:
Details if related
Signed-off-by: Emma Lin emma_lin@edge-core.com