Rename Port member function isPortReady() to allPortsReady() #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <wenni@microsoft.com>
stcheng
approved these changes
Jul 23, 2019
|
Why this change? |
qiluo-msft
approved these changes
Jul 23, 2019
|
There is some idea to enable port one by one once the buffer profile is configured on it. Just make the current logic approach clear. #990 (comment) |
jleveque
approved these changes
Jul 23, 2019
pavel-shirshov
approved these changes
Jul 24, 2019
|
🚀 |
tonytitus
pushed a commit
to tonytitus/sonic-swss
that referenced
this pull request
Jul 31, 2019
…net#990) Signed-off-by: Wenda Ni <wenni@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenda Ni wenni@microsoft.com
What I did
Why I did it
How I verified it
Details if related