Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]: Add Class object in each test script file #992

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Jul 24, 2019

This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

@stcheng stcheng requested a review from lguohan July 24, 2019 20:30
@stcheng
Copy link
Contributor Author

stcheng commented Jul 24, 2019

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build/test_results_analyzer/

to have a better view in the test results analyzer, all the tests need to be put into separated class objects. otherwise, they will be put under (root) directory.

@sonic-net sonic-net deleted a comment from lguohan Jul 25, 2019
@sonic-net sonic-net deleted a comment from lguohan Jul 25, 2019
@sonic-net sonic-net deleted a comment from lguohan Jul 25, 2019
@lguohan
Copy link
Contributor

lguohan commented Jul 25, 2019

I ran multiple tests, I suspect there is some genuine issue in the refactoring.

This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@lguohan
Copy link
Contributor

lguohan commented Jul 27, 2019

retest this please

2 similar comments
@lguohan
Copy link
Contributor

lguohan commented Jul 27, 2019

retest this please

@lguohan
Copy link
Contributor

lguohan commented Jul 27, 2019

retest this please

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge yet, I found the refactor make the test more unstable.

@stcheng
Copy link
Contributor Author

stcheng commented Jul 27, 2019

test_warm_reboot.py::TestWarmReboot::test_system_warmreboot_neighbor_syncup FAILED

this test failed constantly others are fine
i'll check this test

@stcheng
Copy link
Contributor Author

stcheng commented Jul 28, 2019

All checks have passed
2 successful checks
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build-pr/406/
i'll try some more

@stcheng
Copy link
Contributor Author

stcheng commented Jul 28, 2019

retest this please

2 similar comments
@lguohan
Copy link
Contributor

lguohan commented Jul 28, 2019

retest this please

@stcheng
Copy link
Contributor Author

stcheng commented Jul 28, 2019

retest this please

@stcheng stcheng merged commit 7368527 into sonic-net:master Jul 28, 2019
@stcheng stcheng deleted the test branch July 28, 2019 21:15
tonytitus pushed a commit to tonytitus/sonic-swss that referenced this pull request Jul 31, 2019
This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
antony-rheneus pushed a commit to antony-rheneus/sonic-swss that referenced this pull request Aug 1, 2019
This is to get a better JUnitXML file and align all
the tests under the same level of hierarchy.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
Add telemetry service to the list of services to stop/reset-failed/restart during config load/reload operations.
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants