This repository has been archived by the owner on Aug 31, 2022. It is now read-only.
Remove DB Directory removal as part of make clean #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
for single and multi namespace/asic. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
path then always return error. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
packages test cases. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
saiarcot895
approved these changes
Jul 28, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why I did:
As part of PR: #77 i added removal of DB Directory (/var/run/redis) as part of make clean. This is causing issue where other debian package test fails (as they don't see database_config.json) .
Eg: https://dev.azure.com/mssonic/build/_build/results?buildId=25651&view=logs&jobId=cef3d8a9-152e-5193-620b-567dc18af272&j=cef3d8a9-152e-5193-620b-567dc18af272&t=359769c4-8b5e-5976-a793-85da132e0a6f
This issue can come if parallels debian package is getting build and we hit this particular condition.
Possible Enhancement that can be done (not part of this PR)
Going forward we need to see if we can make telemetry depend on sonic-swss-common Debian package so that we can use database_config.json coming from there directly and need not have explicit steps in telemetry makefile.How I did:
Revert PR change of remove db directory in Makefile.