Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Several issue records #2415

Closed
LGH-12 opened this issue Sep 30, 2022 · 2 comments · May be fixed by #2416
Closed

[config] Several issue records #2415

LGH-12 opened this issue Sep 30, 2022 · 2 comments · May be fixed by #2416

Comments

@LGH-12
Copy link

LGH-12 commented Sep 30, 2022

Description

I recorded some issues about config.I hope it is useful.
1、At config/config_mgmt.py:648, there is "Exce" which looks like it should be "Exception".
2、Cmd "config mirror_session erspan add": gre_type is not required. validate_gre_type raise " AttributeError: 'NoneType' object has no attribute 'lower' " if gre_type is not provided.
3、Cmd "config interface cable_length": It is actually "config interface cable-length" at running time and caused by click 7.0 . And It is inconsistent with Command-Reference.
4、Cmd "config route del": In "if not tuple(key.split("|")) in keys and not prefix_tuple in keys", these two look the same.
5、Cmd "config sflow polling-interval": echo error but no return.

Steps to reproduce the issue

1、n/a
2、Run cmd "sudo config mirror_session erspan add TEST 10.10.10.10 10.10.10.11 40 50"
3、Run cmd "config interface -?"
4、n/a
5、Run cmd "config sflow polling-interval 301" and "show sflow"

Describe the results you received

Describe the results you expected

Additional information you deem important (e.g. issue happens only occasionally)

Output of show version

(paste your output here)
@LGH-12
Copy link
Author

LGH-12 commented Sep 30, 2022

I have a pr with fix. Please help in review that.

@LGH-12
Copy link
Author

LGH-12 commented Nov 14, 2022

Hi @bingwang-ms . I noticed you fixed the gre_type in #2458. I have removed that in my PR. Could you please help to review the remaining code or assign someone?

@LGH-12 LGH-12 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant