-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception in adding mirror_session when gre_type
is absent
#2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
approved these changes
Oct 27, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 28, 2022
Update sonic-utilities submodule pointer to include the following: * 4a3d49d Fix exception in adding mirror_session when gre_type is absent ([sonic-net#2458](sonic-net/sonic-utilities#2458)) * 7e7d05c Update the DBmigrator to support persistent loglevel during warm-upgrade ([sonic-net#2370](sonic-net/sonic-utilities#2370)) * c2841b8 [doc]: Update Command-Reference.md ([sonic-net#2444](sonic-net/sonic-utilities#2444)) * 254cafc Event Counters CLI ([sonic-net#2449](sonic-net/sonic-utilities#2449)) * 2dab0d0 [techsupport] Adding FRR EVPN dumps ([sonic-net#2442](sonic-net/sonic-utilities#2442)) * 3c0aece [show][muxcable] add support for show mux firmware version all ([sonic-net#2441](sonic-net/sonic-utilities#2441)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
@bingwang-ms can you create a separate PR for 202205 branch? |
Sure, open another PR for 202205 #2476 |
LGH-12
added a commit
to LGH-12/sonic-utilities
that referenced
this pull request
Nov 14, 2022
Signed-off-by: LTeng <liuteng@asterfusion.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…-net#2458) This PR is to fix the exception in adding mirror session when gre_type is absent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is to fix the exception in adding mirror session when
gre_type
is absent.How I did it
Add a check in
validate_gre_type
. Ifgre_type
is absent, returnNone
directly.How to verify it
Verified by UT and running on a testbed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)