Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show][muxcable] add support for show mux firmware version all #2441

Merged
merged 14 commits into from
Oct 21, 2022

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Oct 15, 2022

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

This PR adds support for show mux firmware version all as well as adds a click confirmation to process event-log
This PR also fixes a permission issue for executing the show mux packetloss command.

$show mux firmware version all

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}

$ show mux firmware version all --active

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}

What I did

How I did it

How to verify it

UT and deploying changes on testbed

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2022

This pull request introduces 1 alert when merging 0ad0815 into abd5eba - view on LGTM.com

new alerts:

  • 1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 1 alert when merging 8187798 into b250701 - view on LGTM.com

new alerts:

  • 1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 1 alert when merging f2572ba into b250701 - view on LGTM.com

new alerts:

  • 1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request introduces 1 alert when merging 2f16fc8 into aedc05e - view on LGTM.com

new alerts:

  • 1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request introduces 1 alert when merging d4f860f into aedc05e - view on LGTM.com

new alerts:

  • 1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2022

This pull request introduces 1 alert when merging f8e3ff8 into aedc05e - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12 vdahiya12 requested a review from zjswhhh October 21, 2022 22:41
zjswhhh
zjswhhh previously approved these changes Oct 21, 2022
Copy link
Contributor

@zjswhhh zjswhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@qiluo-msft
Copy link
Contributor

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

yxieca pushed a commit that referenced this pull request Oct 25, 2022
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

This PR adds support for show mux firmware version all as well as adds a click confirmation to process event-log
This PR also fixes a permission issue for executing the show mux packetloss command.

$show mux firmware version all

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
$ show mux firmware version all --active

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
vdahiya12 added a commit to vdahiya12/sonic-utilities that referenced this pull request Oct 26, 2022
…-net#2441)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

This PR adds support for show mux firmware version all as well as adds a click confirmation to process event-log
This PR also fixes a permission issue for executing the show mux packetloss command.

$show mux firmware version all

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
$ show mux firmware version all --active

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
vdahiya12 added a commit that referenced this pull request Oct 27, 2022
#2457)

* [show][muxcable] add support for show mux firmware version all (#2441)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

This PR adds support for show mux firmware version all as well as adds a click confirmation to process event-log
This PR also fixes a permission issue for executing the show mux packetloss command.

$show mux firmware version all

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
$ show mux firmware version all --active

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}

* remove conflict


Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Oct 28, 2022
Update sonic-utilities submodule pointer to include the following:
* 4a3d49d Fix exception in adding mirror_session when gre_type is absent ([sonic-net#2458](sonic-net/sonic-utilities#2458))
* 7e7d05c Update the DBmigrator to support persistent loglevel during warm-upgrade ([sonic-net#2370](sonic-net/sonic-utilities#2370))
* c2841b8 [doc]: Update Command-Reference.md ([sonic-net#2444](sonic-net/sonic-utilities#2444))
* 254cafc Event Counters CLI ([sonic-net#2449](sonic-net/sonic-utilities#2449))
* 2dab0d0 [techsupport] Adding FRR EVPN dumps ([sonic-net#2442](sonic-net/sonic-utilities#2442))
* 3c0aece [show][muxcable] add support for show mux firmware version all ([sonic-net#2441](sonic-net/sonic-utilities#2441))

Signed-off-by: dprital <drorp@nvidia.com>
preetham-singh pushed a commit to preetham-singh/sonic-utilities that referenced this pull request Nov 21, 2022
…-net#2441)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

This PR adds support for show mux firmware version all as well as adds a click confirmation to process event-log
This PR also fixes a permission issue for executing the show mux packetloss command.

$show mux firmware version all

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_nic_inactive": "0.9MS",
        "version_nic_next": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_peer_inactive": "0.9MS",
        "version_peer_next": "1.0MV",
        "version_self_active": "1.0MV",
        "version_self_inactive": "0.9MS",
        "version_self_next": "1.0MV"
    }
}
$ show mux firmware version all --active

{
    "Ethernet116": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
{
    "Ethernet120": {
        "version_nic_active": "1.0MV",
        "version_peer_active": "1.0MV",
        "version_self_active": "1.0MV"
    }
}
@liuh-80
Copy link
Contributor

liuh-80 commented Feb 2, 2023

202012 branch PR merged: #2457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants