-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copp Changes #1004
Merged
Merged
Copp Changes #1004
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d3f51dd
Copp Changes
0c83b06
Merge branch 'master' of https://github.com/Azure/sonic-utilities int…
439d803
resolving merge
fbf7b22
Addressing code review comments
da0e265
Merge branch 'master' of https://github.com/Azure/sonic-utilities int…
6954f70
UT Fixes
63ccd7b
Merge branch 'master' of https://github.com/Azure/sonic-utilities int…
b781463
Moving migrate copp table to common migration
5310d32
Cleanup
eb43280
Cleanup
3aebe24
Addressing review comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -246,6 +246,14 @@ function backup_database() | |
end | ||
end | ||
" 0 > /dev/null | ||
# Delete COPP_TABLE keys in APPL_DB | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As discussed, we can remove this section |
||
sonic-db-cli APPL_DB eval " | ||
for _, k in ipairs(redis.call('keys', '*')) do | ||
if string.match(k, 'COPP_TABLE:') then | ||
redis.call('del', k) | ||
end | ||
end | ||
" 0 > /dev/null | ||
sonic-db-cli SAVE > /dev/null | ||
#TODO : need a script to copy all rdb files if there is multiple db instances config | ||
docker cp database:/var/lib/redis/$REDIS_FILE $WARM_DIR | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upgrade to version_1_0_5 and create function version_1_0_5 with previous code in version_1_0_4. You need to mark that upgrade is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a discussion with @yxieca . @dgsudharsan, can we do it as part of an outer function so that this is called always instead of copying to each later versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. after offline discussion. I think we need to put 'always apply at latest version' operations after the main upgrade loop.