Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing json needed for DPB CLI #1010

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

samaity
Copy link
Contributor

@samaity samaity commented Jul 28, 2020

Signed-off-by: Sangita Maity sangitamaity0211@gmail.com

- What I did
Importing json module needed for loading json file in DPB.
somehow, missed in #766 PR. 3910 PR in sonic-buildimage is failing for it.

- How I did it
Imported built-in module.

- How to verify it

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
Copy link
Contributor Author

samaity commented Jul 28, 2020

@jleveque somehow missed importing JSON in the previous #766 PR. adding here. Need your help to merge this fix.

@zhenggen-xu
Copy link
Collaborator

retest this please

1 similar comment
@samaity
Copy link
Contributor Author

samaity commented Jul 29, 2020

retest this please

@qiluo-msft qiluo-msft merged commit ef9ac2a into sonic-net:master Jul 30, 2020
CharlieChenEC pushed a commit to CharlieChenEC/sonic-utilities that referenced this pull request May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants