Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config/show]: split vlan into separate file #1038

Merged
merged 7 commits into from
Aug 10, 2020
Merged

[config/show]: split vlan into separate file #1038

merged 7 commits into from
Aug 10, 2020

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Aug 9, 2020

  • add vlan.py in config and show
  • add extensive unit tests for vlan

Signed-off-by: Guohan Lu lguohan@gmail.com

- What I did

  • add vlan.py in config and show
  • add extensive unit tests for vlan

- How I did it

- How to verify it
unit test


---------- coverage: platform linux2, python 2.7.16-final-0 ----------
Name                              Stmts   Miss  Cover
-----------------------------------------------------
config/__init__.py                    0      0   100%
config/aaa.py                       124     75    40%
config/config_mgmt.py               345    116    66%
config/feature.py                    25      5    80%
config/main.py                     2103   1540    27%
config/mlnx.py                      126     85    33%
config/nat.py                       680    570    16%
config/vlan.py                      131     14    89%
show/__init__.py                      0      0   100%
show/bgp_frr_v4.py                   36     36     0%
show/bgp_frr_v6.py                   33     33     0%
show/bgp_quagga_v4.py                20     20     0%
show/bgp_quagga_v6.py                15     15     0%
show/feature.py                      34      0   100%
show/main.py                       1737   1237    29%
show/mlnx.py                         80     62    23%
show/vlan.py                         93     18    81%
utilities_common/__init__.py          0      0   100%
utilities_common/cli.py             162     45    72%
utilities_common/db.py                5      0   100%
utilities_common/intf_filter.py      30     18    40%
utilities_common/netstat.py          35     15    57%
utilities_common/util_base.py        32     32     0%
-----------------------------------------------------
TOTAL                              5846   3936    33%

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

@lguohan lguohan requested a review from jleveque August 9, 2020 05:57
@lguohan
Copy link
Contributor Author

lguohan commented Aug 9, 2020

will enable converge on this report soon.

lguohan
lguohan commented Aug 9, 2020
View reviewed changes
config/aaa.py Show resolved Hide resolved
lguohan
lguohan commented Aug 9, 2020
View reviewed changes
config/main.py Show resolved Hide resolved
lguohan
lguohan commented Aug 9, 2020
View reviewed changes
config/main.py Show resolved Hide resolved
lguohan
lguohan commented Aug 9, 2020
View reviewed changes
config/main.py Show resolved Hide resolved
lguohan
lguohan commented Aug 9, 2020
View reviewed changes
config/main.py Show resolved Hide resolved
lguohan
lguohan commented Aug 9, 2020
View reviewed changes
config/main.py Show resolved Hide resolved
@lgtm-com

This comment has been minimized.

Sign in to view
@lgtm-com

This comment has been minimized.

Sign in to view
lguohan
lguohan commented Aug 9, 2020
View reviewed changes
config/main.py Show resolved Hide resolved
jleveque
jleveque suggested changes Aug 9, 2020
View reviewed changes
utilities_common/cli.py Outdated Show resolved Hide resolved
@lguohan
[config/show]: split vlan into separate file
e1425d8 
- add vlan.py in config and show
- add extensive unit tests for vlan

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
fix lgtm alerts
acf5678 
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
add comments
6c98714 
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2020

This pull request fixes 1 alert when merging 6c98714 into fec442e - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

jleveque
jleveque previously approved these changes Aug 9, 2020
View reviewed changes
jleveque
jleveque reviewed Aug 9, 2020
View reviewed changes
tests/vlan_test.py Outdated Show resolved Hide resolved
@lguohan
fix lgtm alerts
6e4094f 
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
fix import error on show bgp commands
0fc783b 
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
additiona unit test to cover show vlan
52cb719 
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
Copy link
Contributor Author

lguohan commented Aug 9, 2020

@jleveque , find some missing scenarios not cover by unit test. add one unit test to cover it.

jleveque
jleveque suggested changes Aug 9, 2020
View reviewed changes
utilities_common/cli.py Outdated Show resolved Hide resolved
utilities_common/cli.py Outdated Show resolved Hide resolved
@lguohan
add comments
0cbabd9 
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2020

This pull request fixes 1 alert when merging 0cbabd9 into 33ba594 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lguohan lguohan merged commit 0225c09 into sonic-net:master Aug 10, 2020
@lguohan lguohan deleted the vlan branch August 10, 2020 06:20
@ouxlwhu ouxlwhu mentioned this pull request Aug 10, 2020
Closed
@stephenxs stephenxs mentioned this pull request Aug 14, 2020
Merged
3 tasks
@arlakshm arlakshm mentioned this pull request Aug 22, 2020
Open
@chaoskao chaoskao mentioned this pull request Jan 22, 2021
Merged
3 tasks
@tomer-israel tomer-israel mentioned this pull request Aug 2, 2021
Closed
@wangxin wangxin mentioned this pull request Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Cleanup 💧 config Enhancement show Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lguohan @jleveque