Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][Python] Migrate applications/scripts to import sonic-py-common package #1040

Merged
merged 2 commits into from
Aug 14, 2020
Merged

[201911][Python] Migrate applications/scripts to import sonic-py-common package #1040

merged 2 commits into from
Aug 14, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Aug 9, 2020

As part of consolidating all common Python-based functionality into the new sonic-py-common package, this pull request redirects all Python applications/scripts in sonic-utilities repo to point to sonic-py-common and removes multiple duplicate definitions of common functions in the process. This is the next step toward resolving sonic-net/sonic-buildimage#4999.

  • Also reorganize imports for consistency
  • Also align some style

This is a port of #1008 to the 201911 branch

Depends on sonic-net/sonic-buildimage#5132

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com
Copy link

lgtm-com bot commented Aug 13, 2020

This pull request fixes 14 alerts when merging 6ee2538 into ab4b452 - view on LGTM.com

fixed alerts:

  • 14 for Unused import

@jleveque
Copy link
Contributor Author

Check build failure unrelated to this PR.

@jleveque jleveque merged commit d05f354 into sonic-net:201911 Aug 14, 2020
@jleveque jleveque deleted the use_sonic_py_common_201911 branch August 14, 2020 02:21
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
 [201911][Python] Migrate applications/scripts to import sonic-py-common
 package (sonic-net#1040)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants