-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[201911] Fix load minigraph for multi-asic platforms #1124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
smaheshm
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
why don't fix the pfcwd start too, or you prefer cherry picking from master? |
yes cherry-pick |
retest this please |
Retest this please |
1 similar comment
Retest this please |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Enable m_isCombinedMirrorV6Table for BFN platform (sonic-net#1212) [vnet]: Update VNET route table size to 40K for BITMAP implementation (sonic-net#1132) Default action for Egress ACL Table not poulated. (sonic-net#1208) Add/Del lag_name_map item according to lag adding and removing (sonic-net#1124) Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Fix load minigraph on 201911 branch. (sonic-net#1124) Fixed config load_minigrpah not working for Multi-asic platfroms. (sonic-net#1123) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did:
config load_minigraph not working on Multi-asic platforms.
Command config qos reload now runs on all asic so if we using
it with ip netns exec asic0 it creates loop where asic0 can not reach redis server of other asic.
We need this PR #1123 in 201911 for complete fix.
How I did:
config qos reload should be called only once.
Verified:
Tested on single and multi-asic platforms.