Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911] Fix load minigraph for multi-asic platforms #1124

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Sep 22, 2020

Why I did:
config load_minigraph not working on Multi-asic platforms.
Command config qos reload now runs on all asic so if we using
it with ip netns exec asic0 it creates loop where asic0 can not reach redis server of other asic.

We need this PR #1123 in 201911 for complete fix.

How I did:
config qos reload should be called only once.

Verified:
Tested on single and multi-asic platforms.

Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
@abdosi abdosi changed the base branch from master to 201911 September 22, 2020 01:06
Copy link
Contributor

@smaheshm smaheshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@smaheshm
Copy link
Contributor

why don't fix the pfcwd start too, or you prefer cherry picking from master?

@abdosi
Copy link
Contributor Author

abdosi commented Sep 22, 2020

why don't fix the pfcwd start too, or you prefer cherry picking from master?

yes cherry-pick

@abdosi
Copy link
Contributor Author

abdosi commented Sep 22, 2020

retest this please

@jleveque
Copy link
Contributor

Retest this please

1 similar comment
@jleveque
Copy link
Contributor

Retest this please

@abdosi abdosi merged commit 0e5100d into sonic-net:201911 Sep 23, 2020
@abdosi abdosi deleted the 201911_multiasic branch September 23, 2020 15:07
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
 Enable m_isCombinedMirrorV6Table for BFN platform (sonic-net#1212)
[vnet]: Update VNET route table size to 40K for BITMAP implementation (sonic-net#1132)
 Default action for Egress ACL Table not poulated. (sonic-net#1208)
Add/Del lag_name_map item according to lag adding and removing (sonic-net#1124)
Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
 Fix load minigraph on 201911 branch. (sonic-net#1124)
 Fixed config load_minigrpah not working for Multi-asic platfroms.
     (sonic-net#1123)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants