[multi-ASIC] CRM show/config commands changes for multi-asic #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add unit test accordingly. |
|
retest this please |
1 similar comment
|
retest this please |
|
Thanks Joe , @prsunny please take a look ! |
prsunny
previously approved these changes
Nov 4, 2020
|
crm/main.py 310 39 0 87% i can still see some function not covered. can you cover those? improve to 95%+? |
Added more unit tests, the coverage now stands at |
|
retest this please |
prsunny
approved these changes
Nov 10, 2020
lguohan
approved these changes
Nov 10, 2020
judyjoseph
added a commit
to judyjoseph/sonic-utilities
that referenced
this pull request
Nov 13, 2020
abdosi
pushed a commit
that referenced
this pull request
Nov 26, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
49cd91d (HEAD -> 201911, origin/201911) Feature table cli command update (sonic-net#1271) 167d67a [201911] CRM show/config commands changes for multi-asic (sonic-net#1127) (sonic-net#1236) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updated the CRM show/config commands to handle the multi-ASIC platforms.
- How I did it
The threshold setting configured by user is programmed in the CONFIG_DB in all the namespaces. While displaying the thresholds, it is retrieved from the database docker in case of single asic, and from the first namespace docker eg: database0 in case of multi-asic platforms.
The other resources are retrieved from the databases in the respective namespaces and displayed with the additional ASIC name header.
- How to verify it
Verified on the single and multi-asic devices.
- Previous command output (if the output of a command-line utility has changed)
There is no change to the earlier commands in single ASIC. In multi ASIC there will be multiple rows with ASIC name as part of the header.
- New command output (if the output of a command-line utility has changed)