[counterpoll] Disable Counter Poll When Entering Fast Reboot #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Counter polling is enabled via enable_counters script when booting into new image and these configuration is written to config_db. However, subsequent fast-reboot into the same image will have counter polling enabled by default. This affect fast-reboot time. As a workaround, we will disable counter poll when entering fast-reboot. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
|
retest this please |
|
|
||
| # Working on Config DB | ||
| @cli.group() | ||
| def config_db(): |
There was a problem hiding this comment.
This new command is basically "counterpoll disable && config save -y" ?
I wonder, why not disable counterpolling in running redis db and do config save in the fast-reboot script?
There was a problem hiding this comment.
This is possible as well. However I did not want to lose visibility of counters while in the reboot process had it failed in a subsequent step and so, opted for it to be done at a later step.
yxieca
previously approved these changes
Oct 16, 2020
neethajohn
reviewed
Oct 16, 2020
neethajohn
approved these changes
Oct 19, 2020
|
@tahmed-dev please create PR for 201911. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counter polling is enabled via enable_counters script when booting
into new image and these configuration is written to config_db.
However, subsequent fast-reboot into the same image will have counter
polling enabled by default. This affect fast-reboot time. As a workaround,
we will disable counter poll when entering fast-reboot.
Fixes: sonic-net/sonic-buildimage#5107
Closes: sonic-net/sonic-buildimage#5107
singed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- What I did
Disable counterpoll when fast rebooting
- How I did it
Added new command to the counter poll command suite and then invoked it from fast-reboot
- How to verify it
Unit test added
Verified on DUT
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
counterpoll config-db disablecounterpoll config-db enable