Modify fast-reboot script to use BGP script to stop bgp service #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Oct 16, 2020
|
Retest this please |
1 similar comment
|
Retest this please |
| @@ -509,8 +509,7 @@ debug "Stopped radv service..." | |||
|
|
|||
| # Kill bgpd to start the bgp graceful restart procedure | |||
| debug "Stopping bgp ..." | |||
| docker exec -i bgp pkill -9 zebra | |||
| docker exec -i bgp pkill -9 bgpd || [ $? == 1 ] | |||
| systemctl stop bgp | |||
There was a problem hiding this comment.
Will bgp to initiate the bgp graceful restart procedure with systemctl stop bgp?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Call BGP service script to do special handling of reboot process behavior.
This is part of cleanup that is being done for
fast-rebootscript as part of which service shutdown is handled by respective service script instead of populating fast-reboot script.- How I did it
Updated
fast-rebootscript to callsystemctl stop bgpinstead of handling this in the script itself.The service script is already created in
sonic-buildimagerepo as part of sonic-net/sonic-buildimage#3992- How to verify it
Tested
warm-reboot:Tested
fast-rebooton master image on a T0 device.- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)