Fixes the issue with show interface counters and for pfc and queue counters. #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
jleveque
previously approved these changes
Oct 17, 2020
|
retest this please |
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
changed the title
|
@jleveque Can you review again. I had to update for PR for two more changes: a) Fix the Unit-test failure |
jleveque
approved these changes
Oct 20, 2020
abdosi
added a commit
that referenced
this pull request
Oct 21, 2020
…unters. (#1180) * Fix for Issue: sonic-net/sonic-buildimage#5655 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Updated the the fix for pfc/queue counters also. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Fixes the issue with show interface counters and for pfc and queue counters. (sonic-net#1180) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did:
Fix the issues as define sonic-net/sonic-buildimage#5655
How I did:
For Issue 1 : Updated to pass port_speed in ns_util
For Issue 2: Updated ns_diff to return new_value if valid and old_value is not valid.
How I Verify:
For Issue 2:
Manual Verification
After doing sonic-clear during init
show interface counters were fine.