Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SKU create pytest output directory before execution of the script #1226

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

madhanmellanox
Copy link
Contributor

- What I did
I removed the output directory of the SKU create pytest before execution of the script, otherwise the pytest execution will fail when run for the second time.

- How I did it
I checked for existence of the output directory and if it exists, I remove it.

- How to verify it
Run SKU creator pytest for the second time and ensure it runs successfully.

- Previous command output (if the output of a command-line utility has changed)
None

- New command output (if the output of a command-line utility has changed)
None

@madhanmellanox
Copy link
Contributor Author

@jleveque can you please review this? This PR is to avoid the pytest failures seen in sonic-utilities submodule update.

tests/sku_create_test.py Show resolved Hide resolved
@jleveque jleveque merged commit b693cf6 into sonic-net:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants