[tests] Do not trim from PATH if we did not append to it; Clean up/fix shebangs in scripts #1233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Some tests were trimming the last item from system PATH, but they never appended anything to it, thus these tests were trimming valid entries from the tail of the system path, which in turn caused scripts with shebangs like
#!/usr/bin/env python
to fail, because once/usr/bin
was removed from PATH,python
could not be found.- How I did it
#!/usr/bin/python
shebangs with the preferred, more portable#!/usr/bin/env python
in executable scripts- How to verify it
Ensure scripts with
#!/usr/bin/env python
shebangs execute properly in pytests.- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)