[portchannel] Check for member being part of some other portchannel #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request introduces 1 alert when merging 8341aae into 939e331 - view on LGTM.com new alerts:
|
|
retest this please |
|
The same fix has been merged |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Do not set PG to Buffer porfile mapping again if already exist. (sonic-net#1261) [sub intf] Use m_lag_id to be the parent port object id when parent port is LAG (sonic-net#1235)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added message "Interface is already member of portchannel!" if user tries to add a port to a portchannel but if the same port is already made member of some other portchannel.
fix sonic-net/SONiC#360
- How I did it
When port is member of some other portchannel, return message
- How to verify it
Create two portchannels and add member port for first portchannel, try to add this port for second portchannel
admin@sonic: sudo config portchannel add PortChannel0001
admin@sonic: sudo config portchannel add PortChannel0002
admin@sonic: sudo config portchannel member add PortChannel0001 Ethernet4
admin@sonic: sudo config portchannel member add PortChannel0002 Ethernet4
- New command output
Usage: config portchannel member add [OPTIONS] <portchannel_name> <port_name>
Try "config portchannel member add -h" for help.
Error: Interface is already member of portchannel!
Signed-off-by: dmytro_dashkov@Jabil.com