Fix mock SonicV2Connector in python3: use decode_responses mode so caller code will be the same as python2 #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caller code will be the same as python2
jleveque
approved these changes
Nov 13, 2020
tahmed-dev
reviewed
Nov 13, 2020
| @@ -86,6 +95,7 @@ def __init__(self, *args, **kwargs): | |||
| topo = kwargs.pop('topo') | |||
| namespace = kwargs.pop('namespace') | |||
| db_name = kwargs.pop('db_name') | |||
| self.decode_responses = kwargs.pop('decode_responses', False) == True | |||
There was a problem hiding this comment.
is == True necessary here?
There was a problem hiding this comment.
I asked this same question on Qi's earlier similar PR for swsssdk :)
It normalizes decode_responses to always be a Bool. E.g., if kwargs.pop('decode_responses', False) returns None or some other unexpected value. It's basically a failsafe.
There was a problem hiding this comment.
I see, so this is similar to !!<bool> trick in C. It appears to me that is is a bug in the downstream rather that some we should work around it??
There was a problem hiding this comment.
There is no bug in downstream. Here I just program conservatively.
tahmed-dev
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python2 behavior is not changed.
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)