Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify fast-reboot script to use teamd service script #1251

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

vaibhavhd
Copy link
Contributor

@vaibhavhd vaibhavhd commented Nov 18, 2020

- What I did
A new teamd service script has been added in sonic-buildimage as part of the PR - sonic-net/sonic-buildimage#5163

With this change, fast-reboot script will now use the new teamd script to handle killing teamd docker in both fast-boot and warm-boot mode.

- How I did it
Replaced the existing teamd docker handling with the systemctl stop teamd.

- How to verify it
Tested the locally modified script in a DUT for warm-reboot and fast-reboot:

warm-reboot teamd shutdown path:

Nov 19 23:15:01.073902 str-7260cx3-acs-7 NOTICE admin: Stopping teamd ...
Nov 19 23:15:01.080848 str-7260cx3-acs-7 INFO systemd[1]: Stopping TEAMD container...
Nov 19 23:15:01.086341 str-7260cx3-acs-7 NOTICE admin: Stopping teamd service...
Nov 19 23:15:01.278733 str-7260cx3-acs-7 NOTICE admin: Warm boot flag: teamd true.
Nov 19 23:15:01.284320 str-7260cx3-acs-7 NOTICE admin: Fast boot flag: teamd false.
Nov 19 23:15:01.434833 str-7260cx3-acs-7 INFO teamd#supervisor-proc-exit-listener: Process tlm_teamd exited unxepectedly. Terminating supervisor...
Nov 19 23:15:02.435935 str-7260cx3-acs-7 NOTICE teamd#teamsyncd: :- cleanTeamSync: Cleaning up LAG teamd resources ...
Nov 19 23:15:02.437795 str-7260cx3-acs-7 NOTICE teamd#teamsyncd: :- main: Received SIGTERM Exiting
Nov 19 23:15:04.442791 str-7260cx3-acs-7 NOTICE teamd#teammgrd: :- cleanTeamProcesses: Cleaning up LAGs during shutdown...
Nov 19 23:15:04.448515 str-7260cx3-acs-7 INFO teamd#supervisord: teammgrd Daemon not running
Nov 19 23:15:04.449084 str-7260cx3-acs-7 ERR teamd#teammgrd: :- main: Runtime error: /usr/bin/teamd -k -t "PortChannel0001" :
Nov 19 23:15:05.602317 str-7260cx3-acs-7 INFO containerd[522]: time="2020-11-19T23:15:05.601120455Z" level=info msg="shim reaped" id=db0414c94fd3a8ad150850d0e528644ba842c3c2b818cb4b21d3b53aac281d54
Nov 19 23:15:05.611856 str-7260cx3-acs-7 INFO dockerd[639]: time="2020-11-19T23:15:05.610844787Z" level=info msg="ignoring event" module=libcontainerd namespace=moby topic=/tasks/delete type="*events.TaskDelete"
Nov 19 23:15:05.627398 str-7260cx3-acs-7 INFO systemd[1]: var-lib-docker-containers-db0414c94fd3a8ad150850d0e528644ba842c3c2b818cb4b21d3b53aac281d54-mounts-shm.mount: Succeeded.
Nov 19 23:15:05.640344 str-7260cx3-acs-7 INFO systemd[1]: var-lib-docker-overlay2-daea42184e4b9e86cd4c1ed9e616d38378c199a77c432d571bdc5057724ae89a-merged.mount: Succeeded.
Nov 19 23:15:05.820798 str-7260cx3-acs-7 INFO teamd.sh[11184]: teamd
Nov 19 23:15:05.821947 str-7260cx3-acs-7 INFO teamd.sh[1926]: 0
Nov 19 23:15:05.827080 str-7260cx3-acs-7 NOTICE admin: Stopped teamd service...
Nov 19 23:15:05.830923 str-7260cx3-acs-7 INFO systemd[1]: teamd.service: Succeeded.
Nov 19 23:15:05.831685 str-7260cx3-acs-7 INFO systemd[1]: Stopped TEAMD container.
Nov 19 23:15:05.837243 str-7260cx3-acs-7 NOTICE admin: Stopped  teamd ...

fast-reboot teamd shutdown path:

Nov 19 23:34:36.180300 str-7260cx3-acs-7 NOTICE admin: Stopping teamd ...
Nov 19 23:34:36.186619 str-7260cx3-acs-7 INFO systemd[1]: Stopping TEAMD container...
Nov 19 23:34:36.192215 str-7260cx3-acs-7 NOTICE admin: Stopping teamd service...
Nov 19 23:34:36.414572 str-7260cx3-acs-7 NOTICE admin: Warm boot flag: teamd false.
Nov 19 23:34:36.421209 str-7260cx3-acs-7 NOTICE admin: Fast boot flag: teamd true.
Nov 19 23:34:36.597069 str-7260cx3-acs-7 INFO teamd#supervisor-proc-exit-listener: Process tlm_teamd exited unxepectedly. Terminating supervisor...
Nov 19 23:34:36.906270 str-7260cx3-acs-7 INFO containerd[485]: time="2020-11-19T23:34:36.906148279Z" level=info msg="shim reaped" id=db0414c94fd3a8ad150850d0e528644ba842c3c2b818cb4b21d3b53aac281d54
Nov 19 23:34:36.916315 str-7260cx3-acs-7 INFO dockerd[649]: time="2020-11-19T23:34:36.916203497Z" level=info msg="ignoring event" module=libcontainerd namespace=moby topic=/tasks/delete type="*events.TaskDelete"
Nov 19 23:34:36.933087 str-7260cx3-acs-7 INFO systemd[1]: var-lib-docker-containers-db0414c94fd3a8ad150850d0e528644ba842c3c2b818cb4b21d3b53aac281d54-mounts-shm.mount: Succeeded.
Nov 19 23:34:36.962163 str-7260cx3-acs-7 INFO systemd[1]: var-lib-docker-overlay2-daea42184e4b9e86cd4c1ed9e616d38378c199a77c432d571bdc5057724ae89a-merged.mount: Succeeded.
Nov 19 23:34:37.011012 str-7260cx3-acs-7 INFO teamd.sh[1977]: 137
Nov 19 23:34:37.064579 str-7260cx3-acs-7 INFO teamd.sh[10294]: teamd
Nov 19 23:34:37.069420 str-7260cx3-acs-7 NOTICE admin: Stopped teamd service...
Nov 19 23:34:37.073007 str-7260cx3-acs-7 INFO systemd[1]: teamd.service: Succeeded.
Nov 19 23:34:37.075058 str-7260cx3-acs-7 INFO systemd[1]: Stopped TEAMD container.
Nov 19 23:34:37.082920 str-7260cx3-acs-7 NOTICE admin: Stopped teamd ...

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

@vaibhavhd
Copy link
Contributor Author

Retest this please

4 similar comments
@vaibhavhd
Copy link
Contributor Author

Retest this please

@vaibhavhd
Copy link
Contributor Author

Retest this please

@vaibhavhd
Copy link
Contributor Author

Retest this please

@vaibhavhd
Copy link
Contributor Author

Retest this please

@vaibhavhd vaibhavhd marked this pull request as ready for review November 19, 2020 23:40
@vaibhavhd
Copy link
Contributor Author

Retest this please

@vaibhavhd vaibhavhd merged commit 24ffa25 into sonic-net:master Dec 1, 2020
@vaibhavhd vaibhavhd deleted the teamd-update-fastboot branch December 1, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants