Fixing python porting errors in fdbshow, natshow and nbrshow #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
approved these changes
Dec 2, 2020
prsunny
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I fixed python porting errors in fdbshow, natshow and nbrshow scripts.
- How I did it
I removed 'b' from strings of the form b"xxxxx"
- How to verify it
Without the fix, executing show mac, show arp, show nat throws an error related to this python porting error. So, with this fix, the show mac, show arp and show nat scripts execute successfully.
- Previous command output (if the output of a command-line utility has changed)
None
- New command output (if the output of a command-line utility has changed)
None