Fix sonic-installer install for Arista secureboot #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staphylo
force-pushed
the
master-secureboot-rootmount
branch
from
8729bd1
to
c0b9b56
Compare
remove extra blank char #Closed Refers to: sonic_installer/bootloader/aboot.py:40 in 4903140. [](commit_id = 4903140ab34ed4c510a39ddb2f13538f7122574a, deletion_comment = False) |
qiluo-msft
reviewed
Jan 22, 2021
jleveque
suggested changes
Jan 22, 2021
Staphylo
force-pushed
the
master-secureboot-rootmount
branch
2 times, most recently
from
413642a
to
4903140
Compare
jleveque
previously approved these changes
Jan 25, 2021
qiluo-msft
previously approved these changes
Jan 25, 2021
Secureboot on Arista mounts the fs.squashfs directly from the signed SWI file. It is therefore not available at the usual location.
Staphylo
force-pushed
the
master-secureboot-rootmount
branch
from
4903140
to
ea6f493
Compare
|
Just rebased to resolve conflict with |
qiluo-msft
approved these changes
Jan 30, 2021
|
Retest this please |
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…1366) Abstracted away the access to the path of the rootfs via a contextmanager. In Arista secureboot, the rootfs is never extracted on the flash. Instead it's mounted directly from within the signed SWI. The update_sonic_environment function however always assume that the rootfs to be at the same place. - How I did it To alleviate this restriction, a new context manager to obtain the rootfs is introduced. The choice of a context manager rather than a function is entirely based on error management and cleanup. Mounting a squashfs from a swi file requires the use of losetup which makes the rootfs available under /dev/loopX Once done or on error, we need to free this resource which becomes free when using a contextmanager.
daall
pushed a commit
that referenced
this pull request
Apr 21, 2021
Abstracted away the access to the path of the rootfs via a contextmanager. In Arista secureboot, the rootfs is never extracted on the flash. Instead it's mounted directly from within the signed SWI. The update_sonic_environment function however always assume that the rootfs to be at the same place. - How I did it To alleviate this restriction, a new context manager to obtain the rootfs is introduced. The choice of a context manager rather than a function is entirely based on error management and cleanup. Mounting a squashfs from a swi file requires the use of losetup which makes the rootfs available under /dev/loopX Once done or on error, we need to free this resource which becomes free when using a contextmanager.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Remove 00-copp.config.json from swss debian package. (sonic-net#1366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Abstracted away the access to the path of the rootfs via a contextmanager.
In Arista secureboot, the rootfs is never extracted on the flash. Instead it's mounted directly from within the signed SWI.
The
update_sonic_environmentfunction however always assume that the rootfs to be at the same place.- How I did it
To alleviate this restriction, a new context manager to obtain the rootfs is introduced.
The choice of a context manager rather than a function is entirely based on error management and cleanup.
Mounting a squashfs from a swi file requires the use of
losetupwhich makes the rootfs available under/dev/loopXOnce done or on error, we need to free this resource which becomes free when using a contextmanager.
- How to verify it
Use
sonic-installer installon any switch that is an Arista switch with secureboot enabled.For backward compatibility, test the same command on any other switch.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)