[show] Fix int status of LAGs, configured as Vlan members #1478

ghost · 2021-03-04T13:17:07Z

Pass missed argument to function "appl_db_portchannel_status_get" in "intfutil" script to provide correct information in "Vlan" column of command "show int status" for LAG interfaces.

Signed-off-by: Maksym Belei Maksym_Belei@jabil.com

What I did

Resolves sonic-net/sonic-buildimage#6928
Fixed status of LAG interfaces in Vlan column. LAG interfaces, configured as a Vlan member, should be seen as trunk interface.

How I did it

Missed argument "self.combined_int_to_vlan_po_dict" passed to function "appl_db_portchannel_status_get"
in "intfutil" script.

How to verify it

admin@sonic:~$ show int status | grep PortChannel0011
      Ethernet4          4,5,6,7      N/A   9100    N/A     etp2  PortChannel0011    down       up             N/A         N/A
      Ethernet8        8,9,10,11      N/A   9100    N/A     etp3  PortChannel0011      up       up  QSFP+ or later         N/A
PortChannel0011              N/A        G   9100    N/A      N/A           routed    down       up             N/A         N/A
admin@sonic:~$ sudo config vlan member add 11 PortChannel0011
admin@sonic:~$ show vlan brief | grep 11
|        11 |              | PortChannel0011 | tagged         |                       | disabled    |
admin@sonic:~$ show int status | grep PortChannel0011
      Ethernet4          4,5,6,7      N/A   9100    N/A     etp2  PortChannel0011    down       up             N/A         N/A
      Ethernet8        8,9,10,11      N/A   9100    N/A     etp3  PortChannel0011      up       up  QSFP+ or later         N/A
PortChannel0011              N/A        G   9100    N/A      N/A            trunk    down       up             N/A         N/A
admin@sonic:~$ sudo config vlan member del 11 PortChannel0011
admin@sonic:~$ show vlan brief | grep 11
|        11 |              |         |                |                       | disabled    |
admin@sonic:~$ show int status | grep PortChannel0011
      Ethernet4          4,5,6,7      N/A   9100    N/A     etp2  PortChannel0011    down       up             N/A         N/A
      Ethernet8        8,9,10,11      N/A   9100    N/A     etp3  PortChannel0011      up       up  QSFP+ or later         N/A
PortChannel0011              N/A        G   9100    N/A      N/A           routed    down       up             N/A         N/A

prsunny

lgtm

lguohan · 2021-03-11T23:28:27Z

can you update the unit test?

lguohan

need unit test

ghost · 2021-03-15T15:55:27Z

@lguohan, I have added changes in unit tests for intfutil to the PR.

qiluo-msft · 2021-03-15T16:14:33Z

@maksymbelei95 Is this PR needed on 201911 branch?

ghost · 2021-03-15T16:21:24Z

@qiluo-msft, the issue is being occurred on master and 202012 branches, but, did not checked on 201911. I will check and let you know whether the PR is needed on 201911.

qiluo-msft · 2021-03-15T17:03:27Z

Thanks for checking!

ghost · 2021-03-16T09:17:10Z

@qiluo-msft, regarding 201911. The related line of script intfutil looks right:
https://github.com/Azure/sonic-utilities/blob/201911/scripts/intfutil#L402
I think there is no need to cherry-pick the PR to 201911.

qiluo-msft · 2021-03-16T18:58:44Z

@lguohan Could you help review again? Unit test was added.

ghost · 2021-03-23T12:48:41Z

@lguohan, could you review the PR?

prsunny · 2021-03-23T16:38:11Z

@maksymbelei95 , would you please resolve conflict?

* Pass missed argument to function "appl_db_portchannel_status_get" in "intfutil" script to provide correct information in "Vlan" column of command "show int status" for LAG interfaces. Signed-off-by: Maksym Belei <Maksym_Belei@jabil.com>

* Updating mocked tables and related unit test cases of intfutil to check case, when the PortChannel is a member of the Vlan. Command 'show int status' should display such interface as trunk device, not routed. * As there are dependencies between test modules, updating affected unit test modules. Updated: vlan_test.py Signed-off-by: Maksym Belei <Maksym_Belei@jabil.com>

ghost · 2021-03-23T17:57:56Z

@prsunny, done.

ghost · 2021-03-24T09:45:59Z

@prsunny, could you merge the PR?

liat-grozovik · 2021-03-24T15:19:25Z

@maksymbelei95 could you please update submodule to get the fix in master?

ghost · 2021-03-24T19:36:44Z

@liat-grozovik, created PR with the submodule update: sonic-net/sonic-buildimage#7144

Pass missed argument to function "appl_db_portchannel_status_get" in "intfutil" script to provide correct information in "Vlan" column of command "show int status" for LAG interfaces. - What I did Fixed status of LAG interfaces in Vlan column. LAG interfaces, configured as a Vlan member, should be seen as trunk interface. - How I did it Missed argument "self.combined_int_to_vlan_po_dict" passed to function "appl_db_portchannel_status_get" in "intfutil" script. - How to verify it admin@sonic:~$ show int status | grep PortChannel0011 Signed-off-by: Maksym Belei <Maksym_Belei@jabil.com>

ghost mentioned this pull request Mar 4, 2021

Trunk LAG interface is listed as routed port in "show interfaces status" output. sonic-net/sonic-buildimage#6928

Closed

prsunny previously approved these changes Mar 6, 2021

View reviewed changes

prsunny requested a review from qiluo-msft March 6, 2021 00:51

qiluo-msft previously approved these changes Mar 6, 2021

View reviewed changes

lguohan requested changes Mar 11, 2021

View reviewed changes

ghost dismissed stale reviews from qiluo-msft and prsunny via 0a6169e March 15, 2021 12:14

ghost force-pushed the fix_lag_int_status branch 2 times, most recently from 0a6169e to 3dc34bb Compare March 15, 2021 13:01

ghost requested a review from lguohan March 15, 2021 15:47

qiluo-msft previously approved these changes Mar 15, 2021

View reviewed changes

prsunny previously approved these changes Mar 16, 2021

View reviewed changes

liat-grozovik added the Request for 202012 Branch label Mar 16, 2021

liat-grozovik previously approved these changes Mar 16, 2021

View reviewed changes

Maksym Belei added 2 commits March 23, 2021 19:19

ghost dismissed stale reviews from liat-grozovik, prsunny, and qiluo-msft via 52646d6 March 23, 2021 17:50

ghost force-pushed the fix_lag_int_status branch from 3dc34bb to 52646d6 Compare March 23, 2021 17:50

lguohan approved these changes Mar 23, 2021

View reviewed changes

qiluo-msft approved these changes Mar 23, 2021

View reviewed changes

liat-grozovik approved these changes Mar 24, 2021

View reviewed changes

liat-grozovik merged commit c7d4947 into sonic-net:master Mar 24, 2021

yxieca added the Included in 202012 Branch label Mar 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[show] Fix int status of LAGs, configured as Vlan members #1478

[show] Fix int status of LAGs, configured as Vlan members #1478

ghost commented Mar 4, 2021 •

edited by liat-grozovik

Loading

prsunny left a comment

lguohan commented Mar 11, 2021

lguohan left a comment

ghost commented Mar 15, 2021

qiluo-msft commented Mar 15, 2021

ghost commented Mar 15, 2021

qiluo-msft commented Mar 15, 2021

ghost commented Mar 16, 2021

qiluo-msft commented Mar 16, 2021

ghost commented Mar 23, 2021

prsunny commented Mar 23, 2021

ghost commented Mar 23, 2021

ghost commented Mar 24, 2021

liat-grozovik commented Mar 24, 2021

ghost commented Mar 24, 2021

[show] Fix int status of LAGs, configured as Vlan members #1478

[show] Fix int status of LAGs, configured as Vlan members #1478

Conversation

ghost commented Mar 4, 2021 • edited by liat-grozovik Loading

What I did

How I did it

How to verify it

prsunny left a comment

Choose a reason for hiding this comment

lguohan commented Mar 11, 2021

lguohan left a comment

Choose a reason for hiding this comment

ghost commented Mar 15, 2021

qiluo-msft commented Mar 15, 2021

ghost commented Mar 15, 2021

qiluo-msft commented Mar 15, 2021

ghost commented Mar 16, 2021

qiluo-msft commented Mar 16, 2021

ghost commented Mar 23, 2021

prsunny commented Mar 23, 2021

ghost commented Mar 23, 2021

ghost commented Mar 24, 2021

liat-grozovik commented Mar 24, 2021

ghost commented Mar 24, 2021

ghost commented Mar 4, 2021 •

edited by liat-grozovik

Loading