-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the install_requires, no need to exact version as long as there are no broken changes with future versions #1530
Conversation
Two questions:
In reply to: 808638168 |
are no broken changes with future versions
187e7a3
to
85b7db8
Compare
In reply to: 808638168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I misled you. You can revert your last commit. We cannot bump it up just yet, because it conflicts with the sonic-py-common and sonic-platform-common packages, which still install 6.2.1 because they still support Python 2. Thus, we need to remain back on 6.2.1 for now.
pkg_resources.ContextualVersionConflict: (natsort 7.1.1 (/__w/1/s/.eggs/natsort-7.1.1-py3.7.egg), Requirement.parse('natsort==6.2.1'), {'sonic-py-common', 'sonic-platform-common'})
e4079d9
to
85b7db8
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
… are no broken changes with future versions (sonic-net#1530) Fixes sonic-net/sonic-buildimage#7152 Relax the install_requires
… are no broken changes with future versions (sonic-net#1530) #### What I did Fixes sonic-net/sonic-buildimage#7152 #### How I did it Relax the install_requires
What I did
Fixes sonic-net/sonic-buildimage#7152
How I did it
Relax the install_requires
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)