[multi-asic] support show ip bgp neigh/network for multi asic #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
gechiang
reviewed
Apr 23, 2021
|
|
||
| ns_list = multi_asic.get_namespace_list(namespace) | ||
| output = "" | ||
| for ns in ns_list: |
There was a problem hiding this comment.
Question on the overall design to handle multi-ASIC. By looking at how this is implemented it looks like it will cycle through all the name spaces and no attempt to merge/filter but will display whatever each namespace has to the output directly?
There was a problem hiding this comment.
@gechiang, Yes, this command we just display neighbor from all the namespaces. No filtering done for this commands
smaheshm
reviewed
Apr 23, 2021
smaheshm
reviewed
Apr 23, 2021
| type=str, | ||
| show_default=True, | ||
| help='Namespace name or all', | ||
| callback=multi_asic_util.multi_asic_namespace_validation_callback) |
There was a problem hiding this comment.
if it's not lot of work can you explore adding the 'json' dump option.
There was a problem hiding this comment.
I agree, this PR is just adding support for multi asic. We can explore the json option in a future PR
smaheshm
reviewed
Apr 23, 2021
smaheshm
reviewed
Apr 23, 2021
smaheshm
reviewed
Apr 23, 2021
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
gechiang
approved these changes
Apr 27, 2021
abdosi
pushed a commit
that referenced
this pull request
May 4, 2021
This is port of the PR #1574 in 201911 branch This PR is to add support for the commands show ip bgp neighbor and show ip bgp network Add unit tests for these commands
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
…net#1574) This change is to add support for the commands "show ip bgp neighbor "and "show ip bgp network" for multi asic platforms Add unit tests for these commands Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com
What I did
This PR is to add support for the commands
show ip bgp neighborandshow ip bgp networkAdd unit tests for these commands
How I did it
Add change to get the bgp neighbor and network information from each namespace
How to verify it
Check the command works on single and multi asic platforms
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)